If a user is created by normal drupal methods, then tries to login via webserver authentication, the user won't be logged in. This patch changes the user_external_load to a user_load call to take care of this.

CommentFileSizeAuthor
webserver_auth.module.preexisting_users_not_logged_in.patch712 bytesbarry_johnson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

user_external_load() makes our mapping more robust. a user can change his drupal username and still get logged in properly. perhaps we should just forget about that feature. comments?

barry_johnson’s picture

barry_johnson CreditAttribution: barry_johnson commented

I think that is a nice feature to have. It just bit me because I was adding your auth module after we already had several people using the site. Their webserver userid was the same as their drupal userid and it wouldn't work for them the other way. I think mine is a special case and not really the norm. Perhaps we could make it a an admin panel checkbox? Something like "[] allow pre-existing drupal users to authenticate with webserver auth?"
Just thinking out loud..

B.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented

not too fond of that checkbox.

xxvelcrar’s picture

xxvelcrar CreditAttribution: xxvelcrar commented

I was having some issues like this, namely when an account was created before I turned on the auth module. This fixes the SQL error that comes up:

http://drupal.org/node/284515

gaards’s picture

gaards CreditAttribution: gaards commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

Closed because Drupal 5 is not supported. If the issue verifiably applies to later versions, please reopen with details and update the version.