I would like support https://www.drupal.org/project/imagick module (not to be confused with https://www.drupal.org/project/imagemagick).

CommentFileSizeAuthor
#9 3116000-imagick-support-9.patch2.33 KBaspilicious

Issue fork webp-3116000

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xandeadx created an issue. See original summary.

alexmoreno’s picture

alexmoreno CreditAttribution: alexmoreno commented
Status: Active » Postponed

Sebastian Hagens made their first commit to this issue’s fork.

Sebastian Hagens opened merge request !6

Sebastian Hagens’s picture

Sebastian Hagens
Primary language Dutch
Location Breda, Netherlands
CreditAttribution: Sebastian Hagens at Groowup Digital Agency commented
Issue summary: View changes
Status: Postponed » Needs review

I've pushed some changes for imagick support when you're using the drupal/imagick module.
The patch with changes: https://git.drupalcode.org/project/webp/-/merge_requests/6.patch

Sebastian Hagens’s picture

Sebastian Hagens
Primary language Dutch
Location Breda, Netherlands
CreditAttribution: Sebastian Hagens at Groowup Digital Agency commented
Status: Postponed » Needs review

Sebastian Hagens opened merge request !7

Sebastian Hagens closed merge request !7

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
3116000-imagick-support-9.patch2.33 KB

if quality stays optional you get a deprecation warning. I modified the patch.

bvoynick made their first commit to this issue’s fork.

bvoynick’s picture

bvoynick
he/him
Primary language English
CreditAttribution: bvoynick at Interactive Strategies commented
  • Triggered rebase for the existing commits
  • Added Aspilicious' deprecation fix, and also added the new $toolkit param to the method doc
  • Restored use of else (use GD) instead of elseif per andypost's comment
  • Added the 'imagick' toolkit ID possibility to the check on ImageMagick's webp support, too
alexmoreno’s picture

alexmoreno CreditAttribution: alexmoreno commented
alexmoreno’s picture

alexmoreno CreditAttribution: alexmoreno commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.