line 33 of webformblock.module:

$form['#action'] = url(drupal_get_path_alias($_GET['q']), array('fragment' => $anchorname));

If $fragment is assigned a value in webform's additional processing field, that value is passed to the final #anchor output, which is great. But, if you try to set the value of $fragment as null, '', or unset() it, then webformblock resets it to $anchorname. This causes problems when submitting the webform to an external location that does not need the #anchorname appended to the URL.

Two solutions:

Ideal: respect the value of $fragment set in webforms additional processing, even if it is empty or null.

Other: perform a check to see if the target URL is internal or external, and append the #anchor accordingly. I dont know how many external form submissions take advantage of the #anchor so I am not sure what kind of problems omitting it for all external submissions would cause...

Comments

psynaptic’s picture

Status: Needs review » Postponed

This feature needs to be reworked as the messages need to be inline with the form for it to make any sense. Setting to postponed for now as this will need to be revisited when the work takes place.

yang_yi_cn’s picture

Component: Code » Documentation
Status: Postponed » Active

I'm running into some problems because of this line of code, too. What does this line do?

BTW my problem is that when the action is "#" it doesn't work on BlackBerry.