Thanks to the authors for efficient module!
As I see, this project is the only Drupal 7 solution for creating options from Views. It works as it should and, so, it would be nice if the module has been converted to the full project.

Came form here: http://drupal.stackexchange.com/questions/14415/populating-a-webform-sel...

CommentFileSizeAuthor
#12 wvs-code-review-1669186-12.patch1.76 KBmrjmd
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrconnerton’s picture

Assigned: Unassigned » mrconnerton
Status: Active » Postponed

There are a few patches that need to be reviewed and commited. Also I will likely look at just releasing a D7 version of webform_viewreference with that maintainer than creating a separate project.

VinceW’s picture

Matthew,

tnx for your work. The code works as expected.

Looking forward to see this as a full module. If any assistance needed, please let it know.

Best,
VinceW

OFF’s picture

How i can get this module?

This command is not working: "git clone http://git.drupal.org/sandbox/mrconnerton/1373760.git webform_views_select"

And i can't find this project on the github

mrconnerton’s picture

@OFF what error are you getting when you try and clone? I just tried and is woring fine for me.

Triskelion’s picture

I can confirm the git command works fine. I just submitted a patch to #1967000: Detect and allow system paths and remove field formatting. to allow Webform Node Value to work with your code. I would like to add my voice to those requesting you release this as a full project!

mrconnerton’s picture

I would love to release this as a full project but there a quite a few patches that need to be tested and commited. Honestly I don't have a whole lot of time for this project at the moment as now with Drupal 7 99% of the time any use case that I would consider using this module anymore, I can accomplish much beter with entityforms module instead.

If someone who plans to use this often wants to be a co-maintainer to help test and commit these patches, then I'm all for getting the majority commited, tested and then release

Stevel’s picture

Issue summary: View changes

@mrconnerton: #1477974: Allow option to assign key and value in view should be good to commit. If you're still interested in a co-maintainer, I'm still a candidate...

OFF’s picture

Subscribe

mrconnerton’s picture

Status: Postponed » Active

I don't see why we can't promote this project at this point. @Stevel can you look at the project page description and let me know if any of the latest changes should effect it or if you have revisions.

Stevel’s picture

I'm trying to fix the issues PAReview.sh has thrown up. The work in progress is in the issues/2243603-code-style branch (see #2243603: Fix Coder issues). This should probably be done before promoting this to a full project.

mrjmd’s picture

Assigned: mrconnerton » mrjmd

I'm going to continue on the work that has been done with this, assigning it to myself.

mrjmd’s picture

Status: Active » Needs review
FileSize
1.76 KB

Here's a quick run-through of pareview.sh with the latest code base. I also switch from using the deprecated $view->style_options to $view->style_plugins->options.

  • Stevel committed 804949f on 7.x-1.x authored by mrjmd
    Issue #1669186 by mrjmd: Fix PAReview.sh warnings
    
Stevel’s picture

Assigned: mrjmd » mrconnerton
Status: Needs review » Active

Setting this back to active, as the last patch was committed. I believe it's ready to promote to full project now.

Instructions for the project description page:

  1. Create a new view.
  2. Create a "Webform Options" display.
  3. Add the fields you want to use as key and value for the select list as you please.
  4. Set the format to "Webform Select List".
  5. Add the select component to your webform and pick your view under "Load a Pre-Built Option List".
  6. Modify the format options to choose the fields to use as key and value.
Stevel’s picture

Status: Active » Needs review
Stevel’s picture

Title: Request for full D7 project » Promote to full D7 project
Category: Support request » Task
Priority: Normal » Major

This project is ready to become a full Drupal project now. Could you promote it?

mrconnerton’s picture

Status: Needs review » Fixed

I have promoted the project and updated the details on the project page.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kumkum29’s picture

Version: » 7.x-1.x-dev

Hello,

this module seems to be very useful.
do you think create a stable version of this module?

Thanks.