Closed (fixed)
Project:
Webform Score
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Dec 2021 at 11:06 UTC
Updated:
4 Dec 2022 at 20:54 UTC
Jump to comment: Most recent
Comments
Comment #2
hilly510 commentedIt looks like this issue goes deeper, as well. When editing older Webforms with quiz elements, I'm getting a lot of errors in the logs:
Drupal\Component\Plugin\Exception\PluginNotFoundException: The "" plugin does not exist. Valid plugin IDs for Drupal\webform_score\Plugin\WebformScoreManager are: equals, contains, sum, maximum in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of /app/web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).TypeError: Argument 1 passed to Drupal\Core\Form\SubformState::createForSubform() must be of the type array, null given, called in /app/web/modules/contrib/webform_score/src/Plugin/WebformElement/QuizTrait.php on line 119 in Drupal\Core\Form\SubformState::createForSubform() (line 56 of /app/web/core/lib/Drupal/Core/Form/SubformState.php)It seems like the form structure changed with the Webform 6 upgrade, but the code wasn't thoroughly reviewed.
Comment #4
hilly510 commentedI've created a merge request that reuses a lot of the code in the links above, with a few extra lines because they didn't get my all the way to the point of loading in the saved properties.
Comment #5
hilly510 commentedComment #7
nigelcunningham commentedThanks for your work and apologies for my delay in getting around to this.
Looks good to me; merging.