When configuring an element, I check scorable and set a score value. I choose a validation plugin specify any settings. Regardless of what is configured or chosen, it is blank again after I save and re-open the form.

This appears to be due to ThirdPartySettings not actually being saved. They do not get saved automatically. Adding a call to $webform->save() in WebformScore::setScoreConfig resolves the issue.

CommentFileSizeAuthor
#5 2913371-webform-score-not-saving.patch2.07 KBstefank

Comments

cogent created an issue. See original summary.

abutze’s picture

Thanks. It would be great to get this comitted to latest dev version.

socialnicheguru’s picture

Is there a patch

zanoman’s picture

Thanks Cogent,
AFAIU, I tried adding
$webform->save();
in setScoreConfig function in WebformScore.php (unzipped, rezipped package),
uninstalled the module with easyinstall and dumping the core/module/webform_score folder

without luck, still dumping the score settings of the element :(
Could you please elaborate where you added $webform->save()?
Thank you

stefank’s picture

Status: Active » Needs review
StatusFileSize
new2.07 KB

Hi,

Attaching a patch to be able to save the score config data into webform element.

richard.lampitt’s picture

I am also having this issue.

I've applied the patch, but unfortunately it doesn't seem to be working.

rerab jordhen’s picture

it's an issue through ThirdpartySetting so cannot be safe . so adding webform plugin can resolved the issue

vishal choudhary’s picture

@rerab can you please share the screenshot of you facing the issue on this module?
why do we use the Webform Module and you say the issue is resolved?
please provide the steps where you are facing the issue.

nigelcunningham’s picture

I'm working on this at the moment - I have it mostly working but one bit that's still problematic. I'm hoping to finish it tomorrow.

nigelcunningham’s picture

I've just pushed my work on this ticket (and related tickets) to the dev branch and would appreciate any test results others can provide.

nicklundy’s picture

Yes! I can confirm dev branch fixes this issue and I'm now able to save configurations.

nigelcunningham’s picture

Status: Needs review » Fixed
nigelcunningham’s picture

anne-pierre’s picture

Same as #11. I have required the dev branch and a quick test was successful.
Thanks Nigel Cunningham.

nigelcunningham’s picture

Thanks for the feedback!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.