Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3299496-automated-drupal-10-8.patch | 19.96 KB | loopy1492 |
| #3 | webform_scheduled_tasks.2.x-dev.rector.patch | 15.61 KB | project update bot |
| #3 | interdiff-last-bot.6664656.txt | 6.3 KB | project update bot |
| #2 | webform_scheduled_tasks.2.x-dev.rector.patch | 11.63 KB | project update bot |
Issue fork webform_scheduled_tasks-3299496
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
project update bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips
Comment #7
loopy1492 commentedThis is a duplicate of https://www.drupal.org/project/webform_scheduled_tasks/issues/3371376 but I've been using the branch here to figure out what was wrong with that one.
Comment #8
loopy1492 commentedAlthough I've pushed what I believe are decent changes to the other thread, there are still some diffs between the two. I did this branch from scratch, I've tested it, and it seems to be working for me, so I'm going with this one. Attached please find a new static patch file.
Comment #10
devil2005 commentedHi, can you release a stable version please ?
Thanks a lot
Comment #11
mohit_aghera commentedHi @devil2005
I'm already working on this.
I need to review the test case failures happening on this job https://git.drupalcode.org/project/webform_scheduled_tasks/-/jobs/211207
There are phpcs issues which are fairly straight forward.
Checking the test case failures for this one.
Comment #12
mohit_aghera commentedHi @devil2005 @loopy1492
Can you please test the PR and let me know how it goes.
I can merge the PR and cut the new release after doing initial round of testing.
All the tests and code quality checks are green.
Comment #13
devil2005 commentedHi @mohit_aghera,
Thanks a lot i will try it monday, but your 3.X branch is 3 years old on this link git repository that's the correct link ?
Thanks
Comment #14
mohit_aghera commentedHi @devil2005
Yeah, I've recently spinned up a 3.x branch for D10 and onwards support.
2.x branch will be kept for D8 and D9 compatibility.
If you can apply this PR https://git.drupalcode.org/project/webform_scheduled_tasks/-/merge_reque... on 3.x branch.
That way you should be able to test the PR
I can merge after that.
Please let me know if you need additional help.
Comment #15
devil2005 commentedSorry but on "my server", i can't do commands... so i have to put a zip file to use modules... i know it's boring but i can't do otherwise.
If you send me an archive (send me your complete updated module that will be easier), i can test it today
Thansk a lot
Comment #17
mohit_aghera commentedHi @devil2005
I've created a new dev release for your testing.
Feel free to download the dev release from https://ftp.drupal.org/files/projects/webform_scheduled_tasks-3.x-dev.zip and test it out.
Comment #18
devil2005 commentedHi @mohit_aghera
Thanks a lot ! that's perfect for me, installed, tested by upgrade status and migrated on Core 10. And it's ok.
Thanks another time :)
Comment #19
spuky commentedpatches are working for me would love a release
Comment #20
mohit_aghera commentedThanks for testing @spuky
I'll create a new rc release today.
So folks can use it if they need
I am planning to fix few more php8 goodies in 3.x release.
So will keep rc release until we don't make those tweaks.
Meanwhile, we've already a dev release here https://www.drupal.org/project/webform_scheduled_tasks/releases/3.x-dev
Feel free to test out in your existing projects.
Comment #21
mohit_aghera commentedThanks for the testing @spuky @devil2005
3.0.0 release candidate is available to download.
https://www.drupal.org/project/webform_scheduled_tasks/releases/3.0.0-rc1