Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Sticking to dedicated issues per the existing ones.
Replaces calls to file_temp_directory() and file_scan_directory() as well as two method calls that moved away from FileSystem to StreamWrapperManager.
A few calls should be injected, but that would conflict with the constructor issue, and I need a patch that I can combine :)
Comment | File | Size | Author |
---|---|---|---|
#15 | 3121005-15.patch | 891 bytes | aspilicious |
| |||
#11 | 3121005-11.patch | 13.91 KB | jrockowitz |
| |||
#10 | webform-file-system-3121005-10.patch | 13.97 KB | recrit |
| |||
#6 | webform-file-system-3121005-6-interdiff.txt | 1.55 KB | Berdir |
#6 | webform-file-system-3121005-6.patch | 14.53 KB | Berdir |
|
Comments
Comment #2
BerdirComment #4
BerdirAh, that's a change in the API, it needs a valid directory as argument, so that apparently needs to be checked first.
Comment #5
BerdirComment #6
BerdirRerolled and fixed the test fails.
Comment #7
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedIdeally, when possible, I would like to use dependency injection instead of
\Drupal::service('file_system')
.Comment #8
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedAfter rereviewing the patch is seems fine but I need to postpone it until on Drupal 8.8.x is supported.
Comment #9
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #10
recrit CreditAttribution: recrit commentedrerolled against the latest 5.x-dev.
The webform-file-system-3121005-6.patch would not apply for me so I could not get an interdiff.
Comment #11
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #13
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #14
aspilicious CreditAttribution: aspilicious commentedMy project update failed because there is a "file_scan_directory" left in "webform_update_8192".
I also found "file_unmanaged_delete" in the same function.
Comment #15
aspilicious CreditAttribution: aspilicious commentedComment #16
aspilicious CreditAttribution: aspilicious commentedThe update still fails:
But I think that's a different problem but it's an important one to fix before a stable release.
The update tries to fix signatures but I don't have those so the folder doesn't exist.
Comment #17
BerdirOh, that was possibly added in one of the recent security updates?
Comment #19
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented