@see #2936032: Sites named with special characters cannot send mail

CommentFileSizeAuthor
#12 2953597-12.patch6.59 KBjrockowitz
#10 2953597-10.patch3.67 KBjrockowitz
#8 2953597-8.patch47.34 KBjrockowitz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Title: Site name with comma in it cannot send mail to GMail » Fix 'Site name with comma in it cannot send mail to GMail' in WebformEmail handler
gambry’s picture

gambry
Primary language Italian
Location Milan
CreditAttribution: gambry at manifesto commented

Depending by what the recommended solution in #2936032: Sites named with special characters cannot send mail is, we may need to fix the EmailWebformHandler, or webform_mail(), or both.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented

Looks like #2936032: Sites named with special characters cannot send mail is resolved in Drupal 8.6.4+.

@see New \Drupal\Component\Utility\Mail added

The below code needs to be reviewed

\Drupal\webform\Plugin\WebformHandler\EmailWebformHandler::sendMessage
webform_mail()

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Title: Fix 'Site name with comma in it cannot send mail to GMail' in WebformEmail handler » [8.7.x] Fix 'Site name with comma in it cannot send mail to GMail' in WebformEmail handler
Status: Active » Postponed
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Postponed » Needs work

@gambry We could create a temporary copy of Drupal\Component\Utility\Mail in the \Drupal\webform\Utility\WebformMail and use it for older versions of the Webform module.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Title: [8.7.x] Fix 'Site name with comma in it cannot send mail to GMail' in WebformEmail handler » Fix 'Site name with comma in it cannot send mail to GMail' in WebformEmail handler
Status: Needs work » Needs review
FileSize
2953597-8.patch47.34 KB

The attached patch provides a temporary port of the Drupal\Component\Utility\Mail class to the Webform module.

gambry’s picture

gambry
Primary language Italian
Location Milan
CreditAttribution: gambry at manifesto commented

Hey @jrockowitz, #2936032: Sites named with special characters cannot send mail I was thinking about working on a patch to make use of the core Mail utility and add a constraint to the .info.yml/composer.json to drupal/core > 8.6.4. However this will stop sites on version < 8.6.4 to upgrade Webform, which is not ideal at all.

I'm afraid your suggestion of a copy of core Mail utility is currently the best option, and adding the constraint later on i.e. when 8.7.0 is out.

About your patch, is all the stuff not related to Mail required?

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
FileSize
2953597-10.patch3.67 KB

@gambry I accidentally created the patch on the feature branch for #3006765: Webform submission entity access is not enforced in view query.

The attached patch just contains the changes needed for this issue.

Status: Needs review » Needs work

The last submitted patch, 10: 2953597-10.patch, failed testing. View results

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs work » Needs review
FileSize
2953597-12.patch6.59 KB
gambry’s picture

gambry
Primary language Italian
Location Milan
CreditAttribution: gambry at manifesto commented
Status: Needs review » Reviewed & tested by the community

All good from what I can see!

Thanks!!

  • jrockowitz committed 0a35537 on 8.x-5.x 
    Issue #2953597 by jrockowitz: Fix 'Site name with comma in it cannot...
  • jrockowitz committed fa6f988 on 8.x-5.x
    Issue #2953597 by jrockowitz: Fix 'Site name with comma in it cannot...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.