This issue was previously fixed in If radio buttons are required but not filled form is nevertheless submitted but it looks like the fix was removed by mistake in Checkboxes don't support #states required

CommentFileSizeAuthor
#11 2945890-11.patch7.17 KBandypost
#11 2945890-interdiff-10.txt893 bytesandypost
#10 interdiff-2945890-2-10.txt8.14 KBjrockowitz
#10 2945890-10.patch7.16 KBjrockowitz
#8 2945890-8.patch6.3 KBjrockowitz
#8 interdiff-2945890-6-8.txt2.75 KBjrockowitz
#6 interdiff-2-6.txt5.53 KBpiggito
#6 2945890-6.patch8.41 KBpiggito
#2 2945890-2.patch3.51 KBpiggito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

piggito created an issue. See original summary.

piggito’s picture

piggito CreditAttribution: piggito as a volunteer and at Skilld commented
Status: Active » Needs review
FileSize
2945890-2.patch3.51 KB

Attaching patch to re-add the lines fixing the issue.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented 
+++ b/webform.libraries.yml
@@ -660,6 +660,15 @@ webform.element.other:
+  dependencies:
+    - core/drupal
+    - core/jquery
+    - core/jquery.once

jquery.once already depends on jquery

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#2856795: If radio buttons are required but not filled form is nevertheless submitted, +#2856315: Conditional Logic - Requiring Radios in a Fieldset, +#2731991: Setting required on radios marks all options required
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

I guess it related to core issues

- #2945727: Form radios/checkboxes elements should have js-form-wrapper class
- #2731991: Setting required on radios marks all options required

piggito’s picture

piggito CreditAttribution: piggito as a volunteer and at Skilld commented
FileSize
2945890-6.patch8.41 KB
interdiff-2-6.txt5.53 KB

Removing core/jquery dependencies as suggested in #3

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs review » Needs work

The webform.element.radios.js library was moved to webform.states.js

@see https://cgit.drupalcode.org/webform/tree/js/webform.states.js#n78

I did this so that all the #states API code was in one place. My mistake was removing the code to handle radios that are not conditionally required, which should stay in webform.element.radios.js. The code in webform.element.radios.js can be cleaned up and simplified to only handle radios that are not conditionally required.

Below is an example of radios that not conditionally required.

radios_required:
  '#type': radios
  '#title': radios_required
  '#required': true
  '#options': yes_no
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs work » Needs review
FileSize
interdiff-2945890-6-8.txt2.75 KB
2945890-8.patch6.3 KB

The attached patch was tested with the Bartik and Bootstrap theme.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented

Darn. I just noticed my patch did not include any changes to webform.element.radios.js and removed this file.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
FileSize
2945890-10.patch7.16 KB
interdiff-2945890-2-10.txt8.14 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
2945890-interdiff-10.txt893 bytes
2945890-11.patch7.17 KB

Minor nit - no reason to search all over whole DOM in context of behavior

Nice cleanup of deps!

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented

Great catch!!!

  • jrockowitz committed 5f5c7bd on 8.x-5.x authored by andypost 
    Issue #2945890 by jrockowitz, piggito, andypost: Html required...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs review » Fixed

  • jrockowitz committed ff902eb on 8.x-5.x authored by andypost 
    Issue #2945890 by jrockowitz, piggito, andypost: Html required...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.