Problem/Motivation

The token modules includes token validation handling via token_element_validate(). The UX for entering tokens would be significantly improved if we warned users about invalid tokens.

Proposed resolution

Apply token_element_validate() to all text-based elements for all forms that support tokens,

Remaining tasks

  • Add public \Drupal\webform\WebformTokenManager::elementValidate($form, $form_state, $context); which adds 'token_element_validate' to all text-based inputs.
  • Add protected \Drupal\webform\WebformTokenManager::elementValidateRecursive($element, $form_state, $context); which will recursively add 'token_element_validate' to all text-based inputs.
  • Apply WebformTokenManager::elementValidate() to all element, handler, setting, and configuration forms.
  • Write a very basic test that confirms token validation is working correctly. This will require adding the token.module as a 'test_dependencies'

User interface changes

Token validation error message will appear if the token.module is installed and someone enters an invalid token.

Forms that now support with token validation.

/admin/structure/webform/config
/admin/structure/webform/config/submissions
/admin/structure/webform/config/handlers

API changes

None

Data model changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

Issue summary: View changes

  • jrockowitz committed d5ef501 on 2945037-token-validation
    Issue #2945037: Improve token validation
    
jrockowitz’s picture

Status: Active » Needs review
FileSize
24.21 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2945037-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • jrockowitz committed c567984 on 2945037-token-validation
    Issue #2945037: Improve token validation
    
jrockowitz’s picture

Status: Needs work » Needs review
FileSize
24.91 KB

This patch is NOT ready for manual review. I just need to confirm all the tests are passing.

  • jrockowitz committed 11f1ba6 on 2945037-token-validation
    Issue #2945037: Improve token validation
    
jrockowitz’s picture

  • jrockowitz committed 8f03991 on 2945037-token-validation
    Issue #2945037: Improve token validation
    
jrockowitz’s picture

  • jrockowitz committed e966dd0 on 2945037-token-validation
    Issue #2945037: Improve token validation
    

  • jrockowitz committed f806627 on 8.x-5.x
    Issue #2945037 by jrockowitz: Improve token validation
    
jrockowitz’s picture

Status: Needs review » Fixed
jrockowitz’s picture

Status: Fixed » Needs review
FileSize
595 bytes

Minor bug fix.

jrockowitz’s picture

Status: Needs review » Needs work

The last submitted patch, 16: 2945037-16.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

Status: Needs work » Needs review
FileSize
11.87 KB

  • jrockowitz committed 9429d63 on 8.x-5.x
    Issue #2945037 by jrockowitz: Improve token validation
    
jrockowitz’s picture

Status: Needs review » Fixed
jrockowitz’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.