First of thing, Thanks for the great module.

My issue is when i use element type "buttons other", the other field is not working.

var $container = $(this).find('.form-radios');

class "form-radios" is not printed when i used bootstrap theme in some reasons.

so we need to change it to be

var $container = $(this).find('.js-webform-webform_buttons');

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ahmad Abbad created an issue. See original summary.

Ahmad Abbad’s picture

Ahmad Abbad’s picture

Status: Active » Needs review
jrockowitz’s picture

Thanks for the initial patch. The attached patch makes sure 'js-webform-TYPE' class is always added to radios and checkboxes and changes 'js-webform-webform_buttons' to 'js-webform-webform-buttons'.

Ahmad Abbad’s picture

@jrockowitz

Thank you.

Status: Needs review » Needs work

The last submitted patch, 4: 2944716-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

Status: Needs work » Needs review
FileSize
3.77 KB

Status: Needs review » Needs work

The last submitted patch, 7: 2944716-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

Status: Needs work » Needs review
FileSize
4.95 KB

  • jrockowitz committed 377f22f on 8.x-5.x
    Issue #2944716 by jrockowitz, Ahmad Abbad: Element type ' buttons other...
jrockowitz’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.