Aegir creates user 1 with the name of admin. This makes the user creation in the Watershed Now profile conflict.

I changed the uid 1 name to admin and uid 3 to web_admin.

I did not change the name of the author in _watershednow_add_sample_update_feed()

Side note - To install in Aegir I also had to apply this patch to signup module - http://drupal.org/node/824232#comment-3074690

CommentFileSizeAuthor
#6 watershednow-1019876-6.patch1.72 KBjoestewart
#1 watershednow_profile-1019876-1.patch1.4 KBjoestewart
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joestewart’s picture

joestewart CreditAttribution: joestewart commented
FileSize
watershednow_profile-1019876-1.patch1.4 KB
seanberto’s picture

seanberto CreditAttribution: seanberto commented
Assigned: Unassigned » seanberto
Status: Active » Fixed

I don't like making this change b/c I've never thought that it was intuitive that the super user has the most generic username /ever/. Whining, it's also going to through off my support process with existing clients....But that's okay.

The fix is made with: e2cba03..1a62711 master -> master

Love to talk with you about your Aegir deployments for this distro sometime.

joestewart’s picture

joestewart CreditAttribution: joestewart commented

My first patch didn't change user 1. It renamed user 3 from admin. And then also changed the author on the feed node.

Didn't really have a good feel for which was best so submitted the more simple one.

seanberto’s picture

seanberto CreditAttribution: seanberto commented

Huh, as far as I read that patch file, it does rename user 1 from watershednow to admin. That was intentional, right? Re: node creation, not a bit deal.

seanberto’s picture

seanberto CreditAttribution: seanberto commented
Status: Fixed » Closed (fixed)
joestewart’s picture

joestewart CreditAttribution: joestewart commented
FileSize
watershednow-1019876-6.patch1.72 KB

ah, sorry for not being clear. I submitted my second version of changes because it only changed one file. I've tried to create the first version again to explain better. It is untested and was generated from the watershednow profile directory,

edit: as far as the changed username, it could be anything other than "admin", like "web_admin", "web admin" or something totally different.

seanberto’s picture

seanberto CreditAttribution: seanberto commented
Status: Closed (fixed) » Needs review

Aha. that's interesting. What happens if, via Profiler module, the setup of user 1 is also defined in the install profile? Regardless of the username on the account, does Aegir barf?

joestewart’s picture

joestewart CreditAttribution: joestewart commented

Pretty sure it renames the user 1. I went and looked at what it was doing -

http://git.aegirproject.org/?p=provision.git;a=blob;f=platform/drupal/in... ( couldn't find a display for git blame)

52 // create the admin account
53 $account = user_load(1);
54 $edit['name'] = 'admin';
55 $edit['pass'] = user_password();
56 $edit['mail'] = $client_email;
57 $edit['status'] = 1;

I can't test right now, but will try later. Might also bring up with aegir folks if user 1 is defined by the profile, then maybe just stay out of the way instead.