There is no need to call exit, if anything, it should call drupal_exit(), calling exit; prevents things like writing the user session back.

CommentFileSizeAuthor
#1 vud-exit-2315923-1.patch510 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review
FileSize
vud-exit-2315923-1.patch510 bytes

And here's the patch.

marvil07’s picture

marvil07 CreditAttribution: marvil07 commented

@Berdir thanks for pointing that out, yes exit should not be called.

After some research, it seem like the right way to do it is to return a renderable array from those menu callbacks.
I'll be adding that soon.

  • marvil07 committed 4c77c50 on 7.x-1.x authored by Berdir 
    Issue #2315923 by Berdir, marvil07: Do not call exit on vud_vote() and...
marvil07’s picture

marvil07 CreditAttribution: marvil07 commented
Status: Needs review » Fixed
marvil07’s picture

marvil07 CreditAttribution: marvil07 commented
Related issues: +#1710710: ajax_render should not be used; ajax_deliver should be used instead.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.