I tried to get this up and running on SimplyTest.me but got this errror:

PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'sd6d0c042a19f681.visitor_actions_actions' doesn't exist: SELECT a.* FROM {visitor_actions_actions} a; Array ( ) in visitor_actions_get_custom_actions() (line 348 of /home/sd6d0c042a19f681/www/sites/all/modules/visitor_actions/visitor_actions.module).

I think these dependencies should be defined so that they can get picked up. I'm interested in seeing this module in action.

Comments

mgifford’s picture

Project: Acquia Lift Connector » Visitor Actions
Version: 7.x-1.0-beta3 » 7.x-1.x-dev

I got the same error which I explicitly called the Visitor Actions module in SimplyTest.me so think the problem rightly belongs over there.

katbailey’s picture

Mike, can you try installing it locally? It's not clear to me how this can happen - visitor_actions module has the required hook_schema implementation in its .install file for creating the db table so I really don't understand how this error can occur..?

mgifford’s picture

It seems to install fine locally.

patrickd’s picture

The error log:

.....

No release history was found for the requested project [warning]
(variable_store).
Could not download requested project(s). [error]

......

The following extensions will be enabled: visitor_actions, ctools
Do you really want to continue? (y/n): y
WD php: PDOException: SQLSTATE[42000]: Syntax error or access [error]
violation: 1071 Specified key was too long; max key length is 1000
bytes: CREATE TABLE {visitor_actions_actions} (
`id` INT NOT NULL auto_increment COMMENT 'The internal identifier for
any action.',
`machine_name` VARCHAR(255) NOT NULL COMMENT 'The machine-readable
name of the action.',
`label` VARCHAR(255) NOT NULL DEFAULT 'unlabeled' COMMENT 'The label
of the action.',
`plugin` VARCHAR(255) NOT NULL COMMENT 'The plugin defining this
action.',
`event` VARCHAR(255) NOT NULL COMMENT 'The actual event for this
action, e.g. click.',
`identifier` VARCHAR(255) NOT NULL DEFAULT '' COMMENT 'A string that
is used to identify the thing being acted on.',
......
PRIMARY KEY (`id`),
UNIQUE KEY `machine_name` (`machine_name`),
INDEX `plugin_identifier` (`plugin`, `identifier`)
) ENGINE = InnoDB DEFAULT CHARACTER SET utf8; Array
(
)

katbailey’s picture

@patrickd is it clear to you from this what the actual problem is with the schema definition? I'm having trouble inferring which key it's referring to. Here's the schema:
http://drupalcode.org/project/visitor_actions.git/blob/refs/heads/7.x-1....

patrickd’s picture

I guess it's INDEX `plugin_identifier` (`plugin`, `identifier`) but I'm not sure either..

you can create a patch that removes the index post it here, apply & test it on simplytest.me

djdevin’s picture

Yeah, it's that index. Two columns with 255 characters I think is too long for some default MySQL setups. I just removed it and it installed fine.