Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.http://ventral.org/pareview/httpgitdrupalorgprojectviewstimelinejsgit-7x-1x
FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
26 | WARNING | Line exceeds 80 characters; contains 94 characters
59 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...odules/pareview_temp/test_candidate/plugins/date_sources/date_field.inc
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 95 characters
15 | ERROR | Function comment short description must be on a single line
18 | ERROR | Data type of return value is missing
--------------------------------------------------------------------------------
FILE: ...es/pareview_temp/test_candidate/plugins/date_sources/date_iso_field.inc
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 95 characters
15 | ERROR | Function comment short description must be on a single line
18 | ERROR | Data type of return value is missing
--------------------------------------------------------------------------------
FILE: .../pareview_temp/test_candidate/plugins/date_sources/date_stamp_field.inc
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 95 characters
15 | ERROR | Function comment short description must be on a single line
18 | ERROR | Data type of return value is missing
--------------------------------------------------------------------------------
FILE: ...modules/pareview_temp/test_candidate/plugins/date_sources/post_date.inc
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AND 1 WARNING(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
5 | ERROR | File doc comments must be followed by a blank line.
14 | WARNING | Line exceeds 80 characters; contains 95 characters
14 | ERROR | Function comment short description must be on a single line
17 | ERROR | Data type of return value is missing
--------------------------------------------------------------------------------
FILE: ...dules/pareview_temp/test_candidate/plugins/media_sources/file_field.inc
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 88 characters
17 | ERROR | Expected 1 space before variable type
17 | ERROR | Doc comment for var - does not match actual variable name
| | $value at position 1
17 | ERROR | Parameter comment must be on the next line at position 1
--------------------------------------------------------------------------------
FILE: ...ules/pareview_temp/test_candidate/plugins/media_sources/image_field.inc
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
15 | WARNING | Line exceeds 80 characters; contains 88 characters
17 | ERROR | Expected 1 space before variable type
17 | ERROR | Doc comment for var - does not match actual variable name
| | $value at position 1
17 | ERROR | Parameter comment must be on the next line at position 1
--------------------------------------------------------------------------------
FILE: ...dules/pareview_temp/test_candidate/plugins/media_sources/link_field.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
14 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------
FILE: ...mp/test_candidate/plugins/tag_sources/taxonomy_term_reference_field.inc
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
14 | ERROR | Missing function doc comment
22 | ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but
| | found "false"
--------------------------------------------------------------------------------
FILE: ...modules/pareview_temp/test_candidate/plugins/tag_sources/text_field.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
14 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------
FILE: ...es/pareview_temp/test_candidate/plugins/tag_sources/text_long_field.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
14 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------
FILE: ...all/modules/pareview_temp/test_candidate/theme/views-timelinejs.tpl.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
--------------------------------------------------------------------------------
FILE: ...l/modules/pareview_temp/test_candidate/theme/views_timelinejs.theme.inc
--------------------------------------------------------------------------------
FOUND 10 ERROR(S) AFFECTING 10 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
4 | ERROR | Function comment short description must end with a full stop
9 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
12 | ERROR | Expected "switch (...) {\n"; found "switch(...) {\n"
15 | ERROR | BREAK statements must be followed by a single blank line
22 | ERROR | Expected "switch (...) {\n"; found "switch(...) {\n"
25 | ERROR | BREAK statements must be followed by a single blank line
46 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
53 | ERROR | Function comment short description must end with a full stop
57 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------
FILE: ...ew/sites/all/modules/pareview_temp/test_candidate/views_timelinejs.info
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
9 | ERROR | It's only necessary to declare files[] if they declare a class or
| | interface.
10 | ERROR | It's only necessary to declare files[] if they declare a class or
| | interface.
--------------------------------------------------------------------------------
FILE: .../sites/all/modules/pareview_temp/test_candidate/views_timelinejs.module
--------------------------------------------------------------------------------
FOUND 12 ERROR(S) AND 4 WARNING(S) AFFECTING 13 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
13 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar()."
13 | ERROR | Function comment short description must end with a full stop
29 | ERROR | Function comment short description must end with a full stop
43 | WARNING | Line exceeds 80 characters; contains 118 characters
43 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar()."
52 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar()."
64 | ERROR | Function comment short description must be on a single line
78 | ERROR | Expected 1 space(s) before asterisk; 0 found
79 | ERROR | Expected 1 space(s) before asterisk; 0 found
80 | ERROR | Expected 1 space(s) before asterisk; 0 found
80 | ERROR | Return comment must be on the next line
81 | ERROR | Expected 1 space(s) before asterisk; 0 found
87 | ERROR | Missing function doc comment
106 | ERROR | Missing function doc comment
125 | ERROR | Missing function doc comment
--------------------------------------------------------------------------------
FILE: ...review_temp/test_candidate/views_timelinejs_plugin_style_timelinejs.inc
--------------------------------------------------------------------------------
FOUND 30 ERROR(S) AFFECTING 24 LINE(S)
--------------------------------------------------------------------------------
4 | ERROR | The third line in the file doc comment must contain a
| | description and must not be indented
9 | ERROR | Class name must begin with a capital letter
9 | ERROR | Class name must use UpperCamel naming without underscores
11 | ERROR | Missing function doc comment
11 | ERROR | Method name
| | "views_timelinejs_plugin_style_timelinejs::option_definition" is
| | not in lowerCamel format, it must not contain underscores
11 | ERROR | No scope modifier specified for function "option_definition"
29 | ERROR | Missing function doc comment
29 | ERROR | Method name
| | "views_timelinejs_plugin_style_timelinejs::options_form" is not
| | in lowerCamel format, it must not contain underscores
29 | ERROR | No scope modifier specified for function "options_form"
76 | ERROR | Expected "foreach (...) {\n"; found "foreach(...) {\n"
103 | ERROR | Inline doc block comments are not allowed; use "// Comment"
| | instead
218 | ERROR | No scope modifier specified for function "render"
222 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
238 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
239 | ERROR | Expected "foreach (...) {\n"; found "foreach(...) {\n"
243 | ERROR | Expected "foreach (...) {\n"; found "foreach(...) {\n"
262 | ERROR | Inline doc block comments are not allowed; use "// Comment"
| | instead
299 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
309 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
333 | ERROR | Inline doc block comments are not allowed; use "// Comment"
| | instead
362 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
365 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
374 | ERROR | Inline comments must end in full-stops, exclamation marks, or
| | question marks
375 | ERROR | Expected "if (...) {\n"; found "if(...) {\n"
376 | ERROR | If the line declaring an array spans longer than 80 characters,
| | each element should be broken into its own line
383 | ERROR | Missing function doc comment
383 | ERROR | No scope modifier specified for function "getDefinedUsage"
402 | ERROR | Line indented incorrectly; expected 8 spaces, found 10
403 | ERROR | Line indented incorrectly; expected 8 spaces, found 10
404 | ERROR | Line indented incorrectly; expected 8 spaces, found 10
--------------------------------------------------------------------------------| Comment | File | Size | Author |
|---|---|---|---|
| #1 | views_timelinejs-codingstandards-1866752-1.patch | 25.93 KB | FluxSauce |
Comments
Comment #1
FluxSauce CreditAttribution: FluxSauce commentedIntentionally not touching views_timelinejs_plugin_style_timelinejs->render until #1795784: TimelineJS views plugin crashes with content but no mappings is implemented, as that will cause massive merge conflicts. Also ignoring some false positives in views_timelinejs_plugin_style_timelinejs due to the way Views uses classes.
Also cleaned up the README a little to better match the interface, but not to the extent required for #1795778: Enhance README.txt with better set-up instructions.
Comment #2
FluxSauce CreditAttribution: FluxSauce commentedCommitted.