Refactor module

Attached is the patch for review. You'll want to make sure to apply this against 7.x-2.x-dev.

Quite a few files will be replaced and moved to different locations once the patch has been applied. The directory structure should look like this if it is successful:

libraries
-- jquery.li-scroller
---- jquery.li-scroller.js
---- li-scroller.css
-- views_ticker.fade
---- views_ticker.fade.js
theme
-- views-ticker-fade.tpl.php
-- views-ticker-li-scroller.tpl.php
-- views-ticker-marquee.tpl.php
-- views-ticker-newsticker.tpl.php
-- views-ticker-vticker.tpl.php
-- views-ticker-webticker.tpl.php
-- views_ticker_theme.inc
views
-- views_ticker.views.inc
-- views_ticker_plugin_style.inc
-- views_ticker_plugin_style_fade.inc
-- views_ticker_plugin_style_li_scroller.inc
-- views_ticker_plugin_style_marquee.inc
-- views_ticker_plugin_style_newsticker.inc
-- views_ticker_plugin_style_vticker.inc
-- views_ticker_plugin_style_webticker.inc
INSTALL.txt
LICENSE.txt
README.txt
views.ticker.css
views.ticker.js
views_ticker.info
views_ticker.install
views_ticker.module

There is a new version of the patch for review. We identified a couple of minor bugs that needed to be fixed.

We also reviewed the row classes functionality, per the issue in this thread: https://www.drupal.org/node/1825654 There are now options for each style plugin to add a custom row class, and enable/disable row classes for first/last and odd/even.

Reviewing this functionality was quite beneficial, since it allowed us to see that there were still some improvements we could make to the Views templates. They are now very straightforward (and actually they are the same for every plugin):

<div id="<?php print $container_id; ?>"<?php if ($container_class) { print ' class="'. $container_class . '"'; } ?>>
  <ul id="<?php print $list_id; ?>">
    <?php foreach ($rows as $id => $row): ?>
      <li class="<?php print $row_classes[$id]; ?>">
        <?php if ($row_span): ?>
          <span class="<?php print $span_class; ?>">
        <?php endif; ?>
        <?php print $row; ?>
        <?php if ($row_span): ?>
          </span>
        <?php endif; ?>
      </li>
    <?php endforeach; ?>
  </ul>
</div>

We found a couple of additional issues and created a new patch. Everything seems to be working fairly well now. This version also adds support for a different news ticker.

One point worth noting: the news ticker comes with an image used to display controls (play/pause/next/previous). The patch has been created with full index and binary settings, so the image is included. However, for those who are testing, the patch will not create the image file unless it's being run on a server that has Git installed.

See these threads:

How to apply git diff --binary patches without git installed?
http://stackoverflow.com/questions/1910615/how-to-apply-git-diff-binary-...

Applying patches
https://www.drupal.org/patch/apply

I'll attach the image directly to this post in case anyone is having trouble and wants to add it manually. It will need to be put in the following directory (within sites/all/modules, or wherever modules are stored for your site):

/sites/all/modules/views_ticker/libraries/jquery_news_ticker/images/controls.png

When installing patch #5 on a new site, we identified a couple of changes that needed to be made to hook_requirements. See attached.