The ImageFlow Options tab in views is growing quite long, and I see several feature requests, both open and closed, for specific functionality. What I would suggest (and like for my own use) is a text box, in which I can enter options to be passed to the ImageFlow init function.

A single box, where a user can enter options as text, would add a great deal of functionality to the module - there are a dozen or more options that ImageFlow supports but the module doesn't yet.

Unfortunately, my PHP is quite poor, so I can't write a patch myself.

CommentFileSizeAuthor
#7 imageflow_extra_options-907260-2.patch6.11 KBadrinux
#6 imageflow_extra_options-907260-1.patch6.11 KBadrinux
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SteveViselli’s picture

SteveViselli CreditAttribution: SteveViselli commented

Hi,

I don't think a text box for entering options would be a great idea, it leaves to much chance for user error. Not to mention it's a huge security flaw. Some Drupal modules have options lists 10x as long as the current ImageFlow options list, it's not that uncommon.

I recently patched the module to include circular functionality, and I'm planning to work my way through the list of other features ImageFlow supports. In the mean time, you can use my patch (http://drupal.org/node/891268) as an example of how to add support for another ImageFlow option.

Steve

threewestwinds’s picture

threewestwinds CreditAttribution: threewestwinds commented

I'm afraid I don't see how it's a security flaw any worse than the onClickOverride box is. They would basically do the same thing - take a text string and pass it to the ImageFlow init call.

I'd like the box as a supplement for existing options, rather than a replacement. Call is "Advanced Options" or something. but if you're going to work your way through the ImageFlow options, this would only be a place holder.

I'm not real great with PHP, so I've actually been modding the javascript side of things to meet a deadline. I am indeed using the circular patch you linked to. Thanks for that. Any chance that sildeshow, slideshowAutoplay and slideshowSpeed might be next so I can revert to unmodified js files? ;)
-Peter

SteveViselli’s picture

SteveViselli CreditAttribution: SteveViselli commented

Sure thing Peter, I'll make sure I get those features working in my next patch. Shouldn't take too long.

Steve

akalata’s picture

akalata CreditAttribution: akalata commented
Title: Generic options to be passed » Add more options/settings from orginal imageflow.js

Hey Steve,

Are you interested in collaborating on including more options from ImageFlow into the Views Slideshow style/settings panel?

I was able to use your patch for Circular to dig into the code and get the slideshow options working; would love to contribute to a more complete solution.

Here are the basic groupings I have so far:

  • Image Settings
    • General [captions, imageCursor, onClick]
    • Scaling, Resizing, etc [imageScaling, imageFocusM, imagesM, percentLandscape, percentOther]
    • Opactiy [opacity, opacityArray]
    • Reflection [reflections, reflectionGET, reflectionP, reflectionPNG, reflectPath]
  • Player Settings
    • General [aspectRatio, imageFocusMax, imagesHeight, preloadImages, startID]
    • Sliderbar [scrollbarP, slider, sliderCursor, sliderWidth, buttons]
  • Transitions
    • General [animationSpeed, circular, glideToStartID, startAnimation, xStep]
    • Slideshow [slideshow, slideshowSpeed, slideshowAutoplay]
broncomania’s picture

broncomania CreditAttribution: broncomania commented

subscribe is a patch available ?

adrinux’s picture

adrinux CreditAttribution: adrinux commented
FileSize
imageflow_extra_options-907260-1.patch6.11 KB

I've added scrollbar 'buttons' support to @SteveViselli's circular patch from http://drupal.org/node/891268 – so I think this is a more appropriate issue for my patch than that. It's not all the features listed in #4, but it's a start.
Patch against git 6.x-2.x branch attached.

adrinux’s picture

adrinux CreditAttribution: adrinux commented
Status: Active » Needs review
FileSize
imageflow_extra_options-907260-2.patch6.11 KB

Updated patch to fix a stupid error checking settings on existing views.

jefbak2’s picture

jefbak2 CreditAttribution: jefbak2 commented

Subscribing as we would need this option:
Slideshow [slideshow, slideshowSpeed, slideshowAutoplay]

But I don't have shell access to the server (just the ability to add modules via ftp), how can I add the patch?

threewestwinds’s picture

threewestwinds CreditAttribution: threewestwinds commented

You could extract a local copy of the module, apply the patch to that, re-zip the module folder, then upload the zip file as a module.

Shiraz Dindar’s picture

Shiraz Dindar
Location Sooke, BC
CreditAttribution: Shiraz Dindar commented

the patch wouldn't apply to the latest dev as of this date... is it working on the latest for others?

so i went ahead an applied the patch manually. the options showed up -- i checked both circular and buttons options, but neither worked (simply didn't change the view)... i was fairly careful about the manual application, don't think i missed anything... waiting to hear if anyone else has had success...

cheers

ytsejam’s picture

ytsejam CreditAttribution: ytsejam commented

The patch works for me with the latest dev, thanks for it!

aze2010’s picture

aze2010 CreditAttribution: aze2010 commented

subscribing for slideshow, slideshowSpeed, slideshowAutoplay

This would be sooooooooooooooooooo great!

Thanks for this module!!!