Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I just updated the module to 7.x-3.0.
I was using 7.x-3.x-dev(2011-Sep-19).
First off, let me say, this is a brilliant module.
I have just developed an artist showcase site with about a hundred artwork nodes. I use the slideshow extensively.
From the release notes for 7.x-3.0:
#1081436 by osopolar, bensey | camdarley: Added Hide pager when there is only one slide.
There is a problem with this new bit of functionality.
It says in the admin page:
"Hide pager if there is only one slide"
This it is on by default.
The pager is hidden altogether if there is only one slide (I really do not want this).
If I actually click the checkbox @ "Hide pager if there is only one slide".
It hides the all of the items in the pager even if there should be lots of items.
I have a dev site set up with this and I would be very happy to let the module maintainers have access to this to test the functionality.
Thanks
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | views_slideshow-no_controls_or_pager.patch | 1.06 KB | erikhopp |
| #7 | views_slideshow-no_controls-1333026-7.patch | 811 bytes | AaronBauman |
| #4 | 1333026-d6-1.patch | 821 bytes | redndahead |
| #4 | 1333026-d7-1.patch | 821 bytes | redndahead |
| #2 | 1333026-d7-1.patch | 821 bytes | redndahead |
Comments
Comment #1
klonosI see that behavior as well using latest 7.x devs of core, views3 and all related/required modules.
Comment #2
redndahead CreditAttribution: redndahead commentedCan you test if this fixes the issue?
Comment #3
dadderley CreditAttribution: dadderley commentedThank you redndahead for fixing this so quickly.
The patch clears up the problem absolutely.
Comment #4
redndahead CreditAttribution: redndahead commentedThese 2 patches were committed. Thank you for the report and testing.
Comment #5
klonos...yep, confirming fixed. Thanx for your prompt actions Adam ;)
Comment #7
AaronBaumanThis issue strikes again, this time in a different place.
Comment #8
erikhopp CreditAttribution: erikhopp commentedI can confirm that the patch aaronbauman provides in #7 works to show the pager options again when applied.
Comment #9
erikhopp CreditAttribution: erikhopp commentedHmmm. Looks like this is true for the pager as well. Here is a patch. I hope it is helpful.
Comment #10
JvE CreditAttribution: JvE commentedWorks for me.
Comment #11
jonhattanPatch in #1372894: Hide controls if there is only one slide + Jquery Cycle plugin also fixes it.
Comment #12
suldan CreditAttribution: suldan commented#9 works! Thanks for the patch.
Comment #13
kingandy CreditAttribution: kingandy commentedIs this due to be rolled into a stable version any time soon?
Comment #14
abuzakaria CreditAttribution: abuzakaria commentedThe patch works and did fix the issue, but note that the pager doesn't work when before/after advanced options are used. That issue is fixed here: http://drupal.org/node/1343416
Comment #15
wangqizhong CreditAttribution: wangqizhong commentedThanks very much for everyone for the great work on this issue, testing and reviewing.
Patch from #7 was committed against 7.x-3.x at cf8b9ad.
I forgot to grant the commit to aaronbauman so I made a quick fix for coding standards right after by changing a single space at 1c0ad83.
Marking this as fixed for now, but feel free to reopen the ticket or post a new issue if there is still any other problem.
Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyne for the help and great work on this issue.
Cheers!
Comment #16
wangqizhong CreditAttribution: wangqizhong commented