Since the checkbox doesn't have an id, the respective <label> does not have for attribute, and clicking it doesn't toggle the checkbox.

In my case even an empty label takes non empty area and hence is clickable (to style the checkboxes differently), and this missing for breaks the styling for the "Select all" checkbox.

CommentFileSizeAuthor
#2 views_send-select-all-id-2891552-2.patch464 bytesAlex Bukach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Alex Bukach created an issue. See original summary.

Alex Bukach’s picture

Alex Bukach CreditAttribution: Alex Bukach commented
Assigned: Alex Bukach » Unassigned
Status: Active » Needs review
FileSize
views_send-select-all-id-2891552-2.patch464 bytes
hansfn’s picture

hansfn CreditAttribution: hansfn commented
Status: Needs review » Postponed (maintainer needs more info)

Sorry about the late reply.

  1. I'm not able to reproduce the issue. There is no <label> element which is affected by the missing id. (Maybe theme dependent? I tested with a clean Drupal 7.56 using Bartik.)
  2. AFAIK Views Send copies the behaviour of VBO when it comes to the check all checkbox. Consistent behaviour is useful.
hansfn’s picture

hansfn CreditAttribution: hansfn commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Sorry, but I don't see that I will have time to fix any D7 issues.