Hi !
I really like what this module offers, but as soon as I enable it on a Drupal project, the loading time of the modal that allows to add filters in Views doubles since all the filters are duplicated with their (selective) equivalent. This is quite annoying probably because I work with views a lot. Could it be possible to make the selective filters accessible only via a tab "Selective filters" inside the modal. So that by default, when you need to add a new filter, selective filters are not loaded, and for the times you need to add a selective filter, you first click on the tab and then you look for your filter.

What do you think?

Comments

Nicolas Bouteille created an issue. See original summary.

Nicolas Bouteille’s picture

Nicolas Bouteille CreditAttribution: Nicolas Bouteille commented
Title: Do not load selective fields and filters by default, make them accessible via a tab » Do not load selective filters by default, make them accessible via a tab
Issue summary: View changes
Nicolas Bouteille’s picture

Nicolas Bouteille CreditAttribution: Nicolas Bouteille commented

On my current project the modal takes 16 seconds to load.

Nicolas Bouteille’s picture

Nicolas Bouteille CreditAttribution: Nicolas Bouteille commented

For the record, if I disable Views Selective Filters module, the load time drops from 16 seconds to only 7 seconds...
And I just noticed that using Adminimal Theme as my admin theme is another way to speed things up! With Views Selective Filters module still enabled my loading time drops from 16 sec to 9 sec! And if the module is disabled I still gain a few secs, from 7 secs to 5 secs.
So hopefully by moving all the selective filters in another tab, I can have a load time of 5 secs instead of 16 secs with the module still enabled...

david_garcia’s picture

david_garcia CreditAttribution: david_garcia commented

You are 100% right. I had issues on a site with hundreds of fields that was built by a suite builder using just "nodes".

I remember when I took a look at this that it could be solved by rewriting the UI part to be otipimized so it could handle tenths of thousands of fields without issues, but it was too much work with little probablity of making it's way into views or core.

For example, on a site the Ajax request takes 4 seconds, but the rendering takes about 7 seconds. An approach would be to deal with the slow rendering issues.

But if you leverage Drupal's entities (even as a site builder through ECK) you won't run into this problem as the list is limited to the fields that belong to the entity or any of it's bundles.

On my current project the modal takes 16 seconds to load.

Probably, just make sure you measure out of those 16 seconds what belongs to the Ajax request and what to the client rendering.

So... this feature request makes sense but it's some big deal of work to get it properly done.

Nicolas Bouteille’s picture

Nicolas Bouteille CreditAttribution: Nicolas Bouteille commented

Ok thanks for the feedback :) perhaps one day I can have a look at it myself