Rather than having all available entities and fields be indexed–rather time consuming on large sites–what about an alter hook to change supported entities.

CommentFileSizeAuthor
#5 views_natural_sort-supported_entity_alter_hook-2903667-5.patch6.88 KBgeneralredneck
#3 views_natural_sort-supported_entity_alter_hook-2903667-3.patch6.27 KBgeneralredneck
#2 views_natural_sort-type_alter-2903667-1.patch1.29 KBpureawesome
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pureawesome created an issue. See original summary.

pureawesome’s picture

pureawesome CreditAttribution: pureawesome commented
FileSize
views_natural_sort-type_alter-2903667-1.patch1.29 KB
generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
CreditAttribution: generalredneck commented
Status: Active » Needs review
FileSize
views_natural_sort-supported_entity_alter_hook-2903667-3.patch6.27 KB

Just keep in mind your solution is entity Property specific and doesn't affect fields that are being indexed. I've got a different solution in the works at the moment and feel that if I implement this I will have to support some backwards compatibility.

What you have here Works... and it's simple and elegant, but in the grand scheme of the architecture, I'm going to have to look at something different... Probably something closer to the lines of the patch I'm attaching.

My patch is technically less performant than yours because it goes through a bigger dataset currently. I'll be working on this feature more.

The last submitted patch, 2: views_natural_sort-type_alter-2903667-1.patch, failed testing. View results

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
CreditAttribution: generalredneck commented
FileSize
views_natural_sort-supported_entity_alter_hook-2903667-5.patch6.88 KB

Here's a version that passes linting.

Status: Needs review » Needs work

The last submitted patch, 5: views_natural_sort-supported_entity_alter_hook-2903667-5.patch, failed testing. View results

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
CreditAttribution: generalredneck commented

Views has broken tests right now causing the automated tests to not function. see #2903006: Fix tests for 7.x-3.x

  • generalredneck committed 9e3e0f4 on 7.x-2.x 
    Issue #2903667 by generalredneck, pureawesome: Add alter hook to change...
generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
CreditAttribution: generalredneck commented
Status: Needs work » Fixed

I implemented my previous patch. There were several improvements in there that helped build upon other work. Let me know if you have any issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
CreditAttribution: generalredneck commented
Version: 7.x-2.5 » 8.x-2.x-dev
Status: Closed (fixed) » Active
Issue tags: +needs port to Drupal 8

Reopening as this needs a port to D8.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
CreditAttribution: generalredneck at Four Kitchens commented
Status: Active » Fixed

This was handled for D8 in https://git.drupalcode.org/project/views_natural_sort/-/blob/8.x-2.x/src...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.