Broken sql left_join in natural sort text fields due to 'extras' parameter not array

Hi,
I can confirm this. It results in duplicate entries (reduce duplicate entries/pure distinct in views database settings wasn´t helping).
When I turn off natural sort the duplicate entries are gone.
Greetings
Lars

Looking into this.

Yall have any idea on how to reproduce this? when are you seeing the notice? what kinda of entities / content are you sorting naturally?

also see if you have the same issues after upgrading to 2.4

@dotline
can you do me 2 more favors.

Turn on view query in views settings and screenshot or copy and paste the query here.

Next if you wouldn't mind dumping the views_natural_sort table and attaching it as a .txt that would be cool.

Lastly how many languages does the site have? Is the one you are sorting the main site language?

I have the views natural sort module enabled and also receive this error when my search query is two or more words long and one of the words is less than 3 characters long. For example, I get the error when I search "if only" but no error with "this works"

either show the output of SELECT * from views_natural_sort

Or do a SQL dump of that table

The issue is due to a fix that was released in the latest version of Views, as discussed here:

https://www.drupal.org/node/1930288

A number of modules, including this one, are experiencing problems due to the change.

https://www.drupal.org/node/2866370

This issue is being cause by the $extra parameter on the views sort handler for text fields being a string instead of an array.

Replace the 'extra' parameter on lines 34-36 in /handers/views_natural_sort_handler_sort_text_field.inc with:

      'extra' => array(
        array(
          'field' => 'delta',
          'value' => $this->table_alias . '.delta',
        ),
        array(
          'field' => 'entity_type',
          'value' => $table_data['table']['entity type'],
        ),
        array(
          'field' => 'field',
          'value' => preg_replace('/_value$/', '', $this->field),
        ),
      ),

Patch will follow.

Changed the Title to be more descriptive of problem.

Attached is patch on 7.x-2.x

@artis,
Your patch is 0 bytes. Seems you uploaded an empty file.

Rolled the patch that was left in #13. Somehow it works without all the mumbo jumbo about having to worry about the VNS alias and what not... Views has gotten smarter over time adding joins it seems. What I would love to see here are tests.

Bah forgot the Needs Review status.

So I went through and started to make tests. The challenge I'm facing is that for some reason the views_natural_sort handler isn't being applied... but only during the tests. I feel strongly that this is a caching thing... but I can't figure it out thus far. Via my debugging... I've found out that views_natural_sort_text_field_get_configured_fields() and views_natrual_sort_text_get_potential_fields() are both working in finding the field, but it seems that the hook over in views_natural_sort_text_field.views.inc doesn't seem to be called during tests. Running drush en views_natural_sort_text_field_test views_ui; drush eval "views_natural_sort_text_field_test_views_create_test_content();" and then navigating to admin/structure/views/view/views_natural_sort_text_field_test/edit shows everything sorting correctly.

I'll add a seperate issue fixes tests, but rest assure that this is something in the works. You can see this over at http://cgit.drupalcode.org/views_natural_sort/log/?h=7.x-2.x-text_field_...

Gonna mark this one as fixed and get a new release out so that other people don't have so many problems.

Well, that's embarrassing (the empty file), but thanks for taking this and running with it.