Support from Acquia helps fund testing for Drupal Acquia logo

Comments

malcomio created an issue. See original summary.

generalredneck’s picture

Status: Needs review » Needs work
@@ -189,7 +187,7 @@ function views_natural_sort_store(array $index_entry) {
  *     $entity_type - The Entity Type. Ex. node
  *     $field - (optional) reference to the property or field name
  *     $delta - (optional)the item number in that field or property
- *   If an optional parameter doesn't exist, this is treated as a wild care
+ *   If an optional parameter doesn’t exist, this is treated as a wild card
  *   delete
  * @Not-Rewritten
  */

Can you make sure you are using UTF8 when you develop. Also turn off magic quotes. The apostrophe on doesn't is all fudged up

Otherwise... thanks for fixing my obviously hastily created comments and that info file.

generalredneck’s picture

Oh btw... the tests failing are a known issue. There is 1 bug brought to light by the tests in fact with number sorting that needs fixing. Don't be too alarmed.

generalredneck’s picture

Status: Needs review » Needs work

Well that's really odd... another one got added see the word Let's

@@ -151,13 +153,12 @@ function views_natural_sort_store_multiple(array $index_entries) {
  *                be sorted by.
  * @Not-Rewritten
  */
-
 function views_natural_sort_store(array $index_entry) {
   // This should take a formatted object and store it into the views_natural_sort table.
   $string = views_natural_sort_transform($index_entry);
 
-  // The size limit on the content field for views_natual_sort is sometimes not
-  // enough. Lets truncate all data down to that size. I personally feel the
+  // The size limit on the content field for views_natural_sort is sometimes not
+  // enough. Let’s truncate all data down to that size. I personally feel the
   // inaccuracy is an acceptable loss, as the bigger the string gets, the less
   // permanent the sort.
   //
 

generalredneck’s picture

Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.