Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Plan
Port all the working functionalities of this module from D7 to D8.
Code Repo
https://github.com/nehajyoti04/views_matrix.
Would also like to have maintainer access of the module to actively maintain it. Link to the issue #2997902: Co-maintainership requests
Drupal 8 Contrib Porting tracker issue
Comment | File | Size | Author |
---|---|---|---|
#24 | 2933013 -d10-compatibility-24.patch | 2.22 KB | Lukas von Blarer |
Comments
Comment #2
mradcliffeThank you for your contribution.
@drunken_monkey, do you have any plans for Drupal 8 / refactoring?
Comment #3
Eric HeydrichTested the module from the github repository in Drupal 8.4.5 and it works like a charm. I've created a matrix in Drupal 8 Commerce 2.x where I list how many items of a product users have ordered.
Comment #4
nehajyoti CreditAttribution: nehajyoti as a volunteer and at QED42 commented@drunken_monkey
cc : @ mradcliffe
As per Eric Heydrich in the above comment since tested and it works fine, Can I get the maintainer access to maintain the module for both the versions, as there are backlog issues also present on the module issue queue.
Best,
Neha
Comment #5
tstoecklerLast year - before this module existed - I developed a module with the same purpose. Now I finally got around to cleaning it up and contributing it, and I saw this one.
So for now I just created a sandbox as I didn't want to step on any progress done here. I think my version is a bit more elegant than the module here as I re-used the existing Views grouping logic for the Matrix display, which IMO matches the data structure of a matrix quite nicely.
So not really sure what to do. Obviously it would be great to combine efforts on the other hand the two modules are pretty different in their implementation.
In any case, here's the link: https://www.drupal.org/sandbox/tstoeckler/2962081
Comment #6
nehajyoti CreditAttribution: nehajyoti as a volunteer and at QED42 commentedComment #7
drunken monkeySorry for not reacting earlier. I seem to have overlooked this issue.
Thanks, nehajyoti, for pinging me about this!
And, of course, thanks to both you and tstoeckler for contributing your ports!
No, no port planned at the moment. So, I'm fine with adding either of the two "applicants" as maintainers for the D8 branch.
It's a bit awkward, though, that there are two candidates now. What's your take on that?
@ tstoeckler: Would you also be willing to maintain your version if we added that?
@ nehajyoti: Did you take a look at tstoeckler's port? What do you think of it?
If anyone else could give tstoeckler's version a try, that would also be great.
At a glance, tstoeckler's version does look a bit cleaner, and I'm especially impressed that it already comes with test coverage.
Comment #8
gisleUnassigning. The maintainers, not one of the applicants, need to review this.
Comment #9
dqdAnd the issue has been a lil' bit hijacked. It actually was the META port issue which creates the D8 port status link on the project page, which is gone now. It's not a good idea to mix both issues here.
Comment #10
tstoecklerJust realized, I never responded here, sorry. Re #7: Sure, I would be willing to maintain the module.
Comment #11
dqdLet's move co-maintainer issue elsewhere and let's add it here to list of todos for the original META issue. (reversing title edit) I will create a Drupal 8 port tracker issue for you.
Comment #12
dqdCo-maintainer issue: #2997902: Co-maintainership requests (added to the issue summary)
Comment #13
dqdDrupal 8 Contrib Tracker issue added.
Now the
This module is currently being ported to Drupal 8, but is not usable yet. Help us by following this issue.
is visible on the project page and informs about an active porting attempt. ;-)
Comment #14
dqd@tstoeckler and @nehajyoti: can you both please confirm your interest to maintain or co-maintain over here #2997902: Co-maintainership requests ?
And can you discuss here working together to merge code and ideas? This would be great.
Comment #15
dqdComment #16
tstoecklerHey there, sure, it's a good idea to settle the maintainership in a separate issue. Would be great to hear from @nehajyoti here. Like I tried to hint at in #5, I'm totally fine with her version being used if that's what's agreed upon, but of course don't mind my version being used either. Attempting to "merge" both approaches - while that theoretically sounds great - might be a lot of work because it would require someone - ideally someone other than @nehajyoti or me - to identify what the better parts of each version are. And even then it would probably make sense to start with one of the versions and merge the better parts of the version in from there. So not sure how feasible that is.
Comment #17
bwoods CreditAttribution: bwoods at Snake Hill Web Agency commentedJust thought I'd chime in - I tried out both versions of the D8 build and had success with the version that @tstoeckler created. It would be great to get this up in alpha. Let me know if there's anything I can do to help out.
Comment #18
dqd1+ for bwoods testing and reporting. Great to see some progress. I hope the required D.O. buerocracy is no show stopper. It is requried. Let's encourage @tstoeckler and helpers to proceed on this.
Comment #19
Shawn Conn CreditAttribution: Shawn Conn at Luciditi for BKJ Digital commentedAnother +1 here for @tstoeckler work. I've tested/reviewed the sandboxed version and I've found it to be working order.
Comment #20
oldspot CreditAttribution: oldspot at Zoocha commentedTested @tstoeckler 's sandbox version as well after the recommendations above and can confirm as well that it works as expected.
Comment #21
jrochate CreditAttribution: jrochate at ADJ 3 Sistemas commentedAnother successful test on @tstoeckler. Drupal 8.9.8
It would be great to have it as an official version.
I have setup composer to get the package from sandbox with this lines under "repositories":
Comment #22
drunken monkeyUnfortunately, tstoeckler doesn’t seem interested in maintaining his D8 port. I contacted him some time ago to ask again, but no reaction.
So, unless he quickly changes his mind, what would be needed would be someone who’s willing to maintain the D8 port: first merge what’s there and create some release (Alpha, Beta, RC – didn’t review, so no idea what would be appropriate), then monitor the issues to see if anything pops up. Fixing bugs or even working on new features yourself would be nice, but not required – just replying issues, helping with patches and then committing would already be enough.
Any volunteers?
nehajyoti, would you still be interested?
Comment #23
bart lambert CreditAttribution: bart lambert commentedSince D8 is already EOL, Is there a possibility to get a stable D9- release? Need this one urgently!
Comment #24
Lukas von BlarerAttached is a first patch to make the sandbox https://www.drupal.org/sandbox/tstoeckler/2962081 Drupal 10 compatible created using rector.