Views Infinite Scroll module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#10 2930654-10.patch2.42 KBvalthebald
#8 2930654-convert-module_after-patch-8.PNG14.89 KBAkanksha92
#6 interdiff_3-6.txt2.71 KBdeepanker_bhalla
#6 2930654-convert-module-6.patch3.73 KBdeepanker_bhalla
#3 short_array_syntax-2930654-3.patch702 bytesVenkatesh Rajan.J
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Venkatesh Rajan.J created an issue. See original summary.

Venkatesh Rajan.J’s picture

Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at DrupalPartners commented
Assigned: Unassigned » Venkatesh Rajan.J
Venkatesh Rajan.J’s picture

Venkatesh Rajan.J CreditAttribution: Venkatesh Rajan.J as a volunteer and at DrupalPartners commented
Assigned: Venkatesh Rajan.J » Unassigned
Status: Active » Needs review
FileSize
short_array_syntax-2930654-3.patch702 bytes
s.messaris’s picture

s.messaris CreditAttribution: s.messaris commented
Status: Needs review » Reviewed & tested by the community

This looks good to go, it fixes the only remaining use of the long array syntax.

deepanker_bhalla’s picture

deepanker_bhalla CreditAttribution: deepanker_bhalla as a volunteer and at Srijan | A Material+ Company commented
Status: Reviewed & tested by the community » Needs work

@Venkatesh Rajan.J Good work. I can confirm the patch #3 is applying cleanly. Here is the output:

/modules/git/views_infinite_scroll$ git apply -v short_array_syntax-2930654-3.patch

Checking patch views_infinite_scroll.module...
Applied patch views_infinite_scroll.module cleanly.

_________________________________________________________________________________________________________

But after checking with phpcs --standard=Drupal views_infinite_scroll/....... I am getting some more issues i.e. 

FILE: /var/www/html/tolearn/modules/git/views_infinite_scroll/tests/src/FunctionalJavascript/InfiniteScrollTest.php
-------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------
  33 | ERROR | Class constants must be uppercase; expected AJAXWAITDELAY but found ajaxWaitDelay
 119 | ERROR | Type hint "array" missing for $settings
-------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/tolearn/modules/git/views_infinite_scroll/src/EventSubscriber/AjaxResponseSubscriber.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 21 | ERROR | Type hint "array" missing for $commands
------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/tolearn/modules/git/views_infinite_scroll/src/Plugin/views/pager/InfiniteScroll.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
-------------------------------------------------------------------------------------------------------
deepanker_bhalla’s picture

deepanker_bhalla CreditAttribution: deepanker_bhalla as a volunteer and at Srijan | A Material+ Company commented
Status: Needs work » Needs review
FileSize
2930654-convert-module-6.patch3.73 KB
interdiff_3-6.txt2.71 KB

Thus updating the patch with resolved issues. Kindly review.

BramDriesen’s picture

BramDriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
CreditAttribution: BramDriesen as a volunteer and at Capgemini commented
Status: Needs review » Reviewed & tested by the community

Looks good to me :)

Akanksha92’s picture

Akanksha92 CreditAttribution: Akanksha92 commented
FileSize
2930654-convert-module_after-patch-8.PNG14.89 KB

@deepanker_bhalla the patch looks good. The patch applied to the module successfully. Please find the attached screenshot for the same.

Honza Pobořil’s picture

Honza Pobořil CreditAttribution: Honza Pobořil as a volunteer commented
Status: Reviewed & tested by the community » Needs work

Needs reroll.

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at FFW commented
Status: Needs work » Needs review
FileSize
2930654-10.patch2.42 KB

Here's the rerolled patch. Not producing interdiff, since HEAD has changed significantly since the last check
`phpcs --standard=Drupal` now only reports long lines in README.txt

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented

This issue is fixed. Thanks

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.