Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Title of the load more button is wrong.
It should be the same as text value of the button.
It should be Load more instead of current Go to next page
Comment | File | Size | Author |
---|---|---|---|
#11 | views_infinite_scroll-2919747-11.patch | 619 bytes | WillenLeal |
| |||
#3 | views_infinite_scroll-2919747-3.patch | 619 bytes | baikho |
|
Comments
Comment #2
Honza Pobořil CreditAttribution: Honza Pobořil as a volunteer commentedIs this bug also in 1.5 or it was introduced later?
If you will not reply in a ~week I will release 1.6 from the current dev.
Comment #3
baikho@Bobík, to confirm, this replicates in both
dev
and8.x-1.5
originating from 09/10/2015.Comment #4
dddbbb CreditAttribution: dddbbb as a volunteer commentedJust tried the patch in #3 and it works as expected (thanks!). Seems to be a simple enough tweak so daring to mark as RTBC.
Comment #5
Honza Pobořil CreditAttribution: Honza Pobořil as a volunteer commentedI do not think it is right to just put the same text to title attribute because then it is redundant.
Comment #6
dddbbb CreditAttribution: dddbbb as a volunteer commentedTrue. So perhaps there's no need to use the title attribute at all? Either that or make the title attribute configurable.
Comment #7
Honza Pobořil CreditAttribution: Honza Pobořil as a volunteer commentedRemoving could be braking change for users who rely on it.
And is is not important enough to have configuration option.
But if somebody needs to remove it then I recommend to override this template file.
Are there some more arguments for making it configurable?
Comment #8
dddbbb CreditAttribution: dddbbb as a volunteer commentedAll good points. All I would add to that is that we could word the default title attribute to be more generic so that it's more likely to suit a wider variety of different use cases. The current wording "Go to next page" presumes too much about the application/context. Something broader like "Load more results" or "Load more items" would be more useful to more people as a default IMHO.
Comment #9
Honza Pobořil CreditAttribution: Honza Pobořil as a volunteer commentedI am for "Load more items"
Comment #10
dddbbb CreditAttribution: dddbbb as a volunteer commentedComment #11
WillenLeal CreditAttribution: WillenLeal at CI&T commentedChanged the title attribute to "Load more items".
Comment #12
WillenLeal CreditAttribution: WillenLeal at CI&T commentedComment #13
dddbbb CreditAttribution: dddbbb as a volunteer commentedReviewing #11: simple patch, works as expected.
Comment #15
Honza Pobořil CreditAttribution: Honza Pobořil as a volunteer commentedThank you.