Title of the load more button is wrong.

It should be the same as text value of the button.

It should be Load more instead of current Go to next page

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dekisha created an issue. See original summary.

Honza Pobořil’s picture

Is this bug also in 1.5 or it was introduced later?

If you will not reply in a ~week I will release 1.6 from the current dev.

baikho’s picture

Status: Active » Needs review
FileSize
619 bytes

@Bobík, to confirm, this replicates in both dev and 8.x-1.5 originating from 09/10/2015.

dddbbb’s picture

Status: Needs review » Reviewed & tested by the community

Just tried the patch in #3 and it works as expected (thanks!). Seems to be a simple enough tweak so daring to mark as RTBC.

Honza Pobořil’s picture

I do not think it is right to just put the same text to title attribute because then it is redundant.

dddbbb’s picture

I do not think it is right to just put the same text to title attribute because then it is redundant.

True. So perhaps there's no need to use the title attribute at all? Either that or make the title attribute configurable.

Honza Pobořil’s picture

Removing could be braking change for users who rely on it.

And is is not important enough to have configuration option.

But if somebody needs to remove it then I recommend to override this template file.

Are there some more arguments for making it configurable?

dddbbb’s picture

All good points. All I would add to that is that we could word the default title attribute to be more generic so that it's more likely to suit a wider variety of different use cases. The current wording "Go to next page" presumes too much about the application/context. Something broader like "Load more results" or "Load more items" would be more useful to more people as a default IMHO.

Honza Pobořil’s picture

I am for "Load more items"

dddbbb’s picture

Status: Reviewed & tested by the community » Needs work
WillenLeal’s picture

Changed the title attribute to "Load more items".

WillenLeal’s picture

Status: Needs work » Needs review
dddbbb’s picture

Status: Needs review » Reviewed & tested by the community

Reviewing #11: simple patch, works as expected.

  • WillenLeal authored 88ea1b0 on 8.x-1.x
    Issue #2919747 by WillenLeal, baikho: Button title is wrong
    
Honza Pobořil’s picture

Status: Reviewed & tested by the community » Fixed

Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.