Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I have a gallery set up now with Gallerific. I noticed that if I click the same picture more than once in quick succession (totally possible in todays fast paced clicking world) the image is loaded multiple times underneath.
It's kinda hard to explain so I've attached an image showing what is happening. Is there a fix for this? This is the last big element of a site I'm developing that will launch soon- I'll have to find a new gallery if I can't find a remedy.
Comment | File | Size | Author |
---|---|---|---|
#23 | views_galleriffic-loading-multiple-images-873014-23.patch | 618 bytes | ressa |
#5 | views_galleriffic-873014.patch | 5.82 KB | manfer |
gallerificIssue.jpg | 34.28 KB | macandrow |
Comments
Comment #1
macandrow CreditAttribution: macandrow commentedOk, this issue still persists. Has no one else run into this?
Comment #2
acouch CreditAttribution: acouch commentedDo you have other modules that use jquery or javascript on your site? If so can you remove them and see if this behavior still persists? What browser / OS are you using? Does this happen on all browsers for you? Awesome photo btw!
Comment #3
manfer CreditAttribution: manfer commentedI think this is something that happens in galleriffic itself. You can make it happen on gallerific minimal implementation example.
On the rest of galleriffic examples that is not happening.
I don't know the inner working of that library but it seems the examples that don't have that issue are using one library init parameter, syncTransitions: true, which by default has a false value. I mean,
Comment #4
acouch CreditAttribution: acouch commentedhi Manfer:
thanks for finding that. @macandrow, if you change 'syncTransitions: true,' to the module file (around line 35) does it fix that behavior?
Comment #5
manfer CreditAttribution: manfer commentedPatch againts 6.x-1.x-dev that adds a sync transitions option to the galleriffic style after autostart option, so it can be configured as true or false.
Comment #6
acouch CreditAttribution: acouch commentedThanks. Patch looks good. Will commit when I get a chance.
Comment #7
macandrow CreditAttribution: macandrow commented@aaroncouch behavior is fixed, I'll patch everything up just to be safe.
Comment #8
mrgoltra CreditAttribution: mrgoltra commentedHello,
Wondering if the patch has been committed current release or dev?
Thank you,
Mark
Comment #9
acouch CreditAttribution: acouch commentedNot yet. Promise to in the next couple of days.
Comment #10
adasgt CreditAttribution: adasgt commentedHi acouch,
The issue still persists in version 6.x.1.1.
Any idea when the fix will be available.
Changing the "syncTransitions" to true in "jquery.gallerific.js" file partially fixes the problem. Though it does not load multiple images, but during transition to next image, previous image is still visible for few seconds.
Thanks
Comment #11
adasgt CreditAttribution: adasgt commentedIssue resolved: Edit jquery.galleriffic.js file and add following lines:
1.
Add the following line after line # 627 i.e. var nextIndex = this.getNextIndex(imageData.index);
this.$imageContainer.empty();
2.
Add the following line after line # 641 i.e. var newCaption = 0;
this.$captionContainer.empty();
Check the issue @ http://code.google.com/p/galleriffic/issues/detail?id=95&q=multiple%20image
Comment #12
acouch CreditAttribution: acouch commentedThanks adasgt
I will commit this as soon as I am able.
Comment #13
thedavidmeister CreditAttribution: thedavidmeister commentedplease commit this!
double clicking a thumbnail causes the number of slides visible to increase.
many casual users double click just about everything, so this totally breaks the gallery.
Comment #14
thedavidmeister CreditAttribution: thedavidmeister commentedincidently #11 fixed this for me :) thanks!
Comment #15
acouch CreditAttribution: acouch commentedI have updated the way that the js loads.
I didn't commit get a chance to commit the fixes above as I think the changes I made should stop this from happening.
Can folks who had this problem please update and test?
If it is still an issue I will promptly commit those changes in the js file.
Thanks!
Comment #16
joeytheman CreditAttribution: joeytheman commentedI was experiencing the same issue and #11 worked for me also.
Comment #17
acouch CreditAttribution: acouch commentedSeems like this is fixed.
Comment #18
dlufkinThis is still an issue. The fixes in #11 work, but they need to be committed to the js.
Patch applied, functioning properly: http://swellfineart.com/gallery-hubley-waves
Patch not applied, not functioning properly: http://swell.goodpagescom/gallery-hubley-waves
Comment #19
acouch CreditAttribution: acouch commentedHave you upgraded to the latest version?
Comment #20
acouch CreditAttribution: acouch commentedClosing this unless someone else is still having issues. Please download the latest version before re-opening.
Comment #21
ressa CreditAttribution: ressa commentedStill an issue in version 7.x-1.1, adding the two lines mentioned in post #11 fixes it, thanks @adasgt.
Comment #22
acouch CreditAttribution: acouch commentedIf this is working for you can you please submit a patch against the latest dev version?
Comment #23
ressa CreditAttribution: ressa commentedHere is the patch for Views Galleriffic.
I hope I haven't messed up too badly, it's my first git patch :-)
Comment #24
acouch CreditAttribution: acouch commentedIf someone can find the time to RTBC this I will gladly commit. Sorry I don't have time myself right now. But if it is RTBCed I will commit immediately.
Comment #25
Spieler CreditAttribution: Spieler commented#11 (comment) Worked for me.
Thanks
Comment #26
m.stenta#23 works. RTBC!
Also, closing #1908052: Duplicate Images on double-click as a duplicate.