As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#3 PluginViewsFieldView_spellcheck-2766941-3.patch693 bytesShabbir
#2 removed-file-docblock-2766941.patch562 bytesaks22
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aks22 created an issue. See original summary.

aks22’s picture

aks22 CreditAttribution: aks22 as a volunteer and at Cybage Software Pvt Ltd. commented
Status: Active » Needs review
FileSize
removed-file-docblock-2766941.patch562 bytes

Please find attached patch file.

Shabbir’s picture

Shabbir CreditAttribution: Shabbir at Trigyn Technologies Ltd commented
Assigned: aks22 » Shabbir
FileSize
PluginViewsFieldView_spellcheck-2766941-3.patch693 bytes

There is also a small spellcheck in the view.php file. Attaching the patch for it as well.

Shabbir’s picture

Shabbir CreditAttribution: Shabbir at Trigyn Technologies Ltd commented

Sorry, wrong post this needs to be opened as a different issue altogether

aks22’s picture

aks22 CreditAttribution: aks22 as a volunteer and at Cybage Software Pvt Ltd. commented

I have raised the issue for drupal standard 'https://www.drupal.org/coding-standards/docs'.

For the patch you have added here, create another issue for spelling mistake and post patch.

Shabbir’s picture

Shabbir CreditAttribution: Shabbir at Trigyn Technologies Ltd commented
Assigned: Shabbir » Unassigned
Shabbir’s picture

Shabbir CreditAttribution: Shabbir at Trigyn Technologies Ltd commented

Yes indeed, I have already created a new issue and have posted my patch over there.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thanks, @aks22.

  • jibran committed 91f01e9 on 8.x-1.x authored by aks22 
    Issue #2766941 by aks22, jibran: PHP files modification as per drupal...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

Committed and pushed to 1.x

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.