Problem/Motivation

Need to add opportunity to use Western Europe ISO-8859-15 encoding for export data. Also with this need to fix utf-8 encoding name.

CommentFileSizeAuthor
#11 interdiff_2931152-9-11.txt705 byteslmotisi
#11 2931152-11.patch2.16 KBlmotisi
#9 2931152-9.patch3.15 KBandypost
#9 interdiff.txt580 bytesandypost
#8 2931152-8.patch3.15 KBandypost
#8 interdiff.txt1.15 KBandypost
#5 2931152-5.patch2.08 KBYurkinPark
#2 views_data_export-2931152-2.patch1.96 KBr.nabiullin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nabiyllin created an issue. See original summary.

r.nabiullin’s picture

r.nabiullin CreditAttribution: r.nabiullin as a volunteer and at Skilld commented
Status: Active » Needs review
FileSize
views_data_export-2931152-2.patch1.96 KB

Integration with csv_serialization was added in this issue.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented 
+++ b/src/Plugin/views/style/DataExport.php
@@ -35,7 +35,7 @@ class DataExport extends Serializer {
-      'encoding' => ['default' => 'utf8'],
+      'encoding' => ['default' => 'utf-8'],

@@ -128,7 +128,8 @@ class DataExport extends Serializer {
-              'utf8' => $this->t('UTF-8'),
+              'utf-8' => $this->t('UTF-8'),

Why you adding `-`? that breaks existing config

r.nabiullin’s picture

r.nabiullin CreditAttribution: r.nabiullin as a volunteer and at Skilld commented

utf-8 it's a correct name. This option (encoding) was ported from D7 and on current version this option was without powerful and absolutely never been used. But for new csv serialization need to update this option.

YurkinPark’s picture

YurkinPark CreditAttribution: YurkinPark at Skilld commented
FileSize
2931152-5.patch2.08 KB

Re-roll

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

I still feel this needs split into upgrade of s/utf8/utf-8 and new encoding

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Human Rights Watch commented
Status: Reviewed & tested by the community » Needs review

Shouldn't there be an update hook here to change the option for existing sites as noted in #6?

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
interdiff.txt1.15 KB
2931152-8.patch3.15 KB

Here's upgrade tests

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
FileSize
interdiff.txt580 bytes
2931152-9.patch3.15 KB

Fix name

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue tags: -csv_serialization
lmotisi’s picture

lmotisi CreditAttribution: lmotisi at Koriolis commented
FileSize
2931152-11.patch2.16 KB
interdiff_2931152-9-11.txt705 bytes

I updated #9 to add UTF-16LE and UTF-16BE option, and I also created a patch for csv_serialization