Cache Tags not added to view [#3322830]

Problem/Motivation

When adding cache tags to a view, they show up in the X-Drupal-Cache-Tags header correctly. When invalidating the tags nothing happens. Invalidating the existing (system) cache tag from the view clears the cache tag correctly, but custom cache tags not. Looking in the database the cache tags aren't added to the cache_render table at all, only the existing ones (for example "config:views.view.listing_1 rendered").

Custom cache tag added: custom:view.listing_1.user.{{ raw_arguments.null }}, which shows up in X-Drupal-Cache-Tags correctly like custom:view.listing_1.user.1

Version: Drupal 9.4.5 / Views 9.4.5 / Views Custom Cache Tag: 8.x-1.2

Comment	File	Size	Author
#7	3322830-cache-tags.patch	1021 bytes	ciprian.stavovei

Issue fork views_custom_cache_tag-3322830

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3322830-cache-tags-not changes, plain diff MR !6
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

21 November 2022 at 08:15

pablovos created an issue. See original summary.

Comment #2

pablovos commented 21 November 2022 at 08:15

Title:

Cache Tags not added to

» Cache Tags not added to view

Comment #3

pablovos commented 23 November 2022 at 10:29

I wrongly assumed that CustomTags would also be added to individual rows but this is not the case. Adding this code to src/Plugin/views/cache/CustomTag.php solved the issue for us:

/**
 * {@inheritdoc}
 */
public function getRowCacheTags(\Drupal\views\ResultRow $row) {
  $tags = parent::getRowCacheTags($row);

  $custom_tags = preg_split('/\r\n|[\r\n]/', $this->options['custom_tag']);
  $custom_tags = array_map('trim', $custom_tags);
  $custom_tags =  array_map(function ($tag){ return $this->view->getStyle()->tokenizeValue($tag, 0);}, $custom_tags);

  $tags = Cache::mergeTags($custom_tags, $tags);

  return $tags;
}

Comment #4

berdir

German

Switzerland

commented 23 November 2022 at 12:05

haven't really seen that before, I think entity rendered views don't use that, we usually use those. Makes sense, can you create that as a patch or merge request?