The Views Custom Cache Tags module does not implement hook_help().

CommentFileSizeAuthor
#5 hook_help_added-2997408-05.patch1.48 KBsiddhant.bhosale
#3 hook_help_added-2997408-03.patch1.49 KBsiddhant.bhosale

Issue fork views_custom_cache_tag-2997408

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Akshay kashyap created an issue. See original summary.

siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: Unassigned » siddhant.bhosale
siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: siddhant.bhosale » Unassigned
Status: Needs work » Needs review
StatusFileSize
new hook_help_added-2997408-03.patch1.49 KB

Adding hook_help() to views_custom_cache_tag.

Status: Needs review » Needs work

The last submitted patch, 3: hook_help_added-2997408-03.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

siddhant.bhosale’s picture

siddhant.bhosale commented
Status: Needs work » Needs review
StatusFileSize
new hook_help_added-2997408-05.patch1.48 KB

I have forgot to run phpcs and phpcbf. here is the new patch.

Status: Needs review » Needs work

The last submitted patch, 5: hook_help_added-2997408-05.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

siddhant.bhosale’s picture

siddhant.bhosale commented
Status: Needs work » Needs review

Error on CI seems to be different from hook_help. Marking this as Needs review.

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Status: Needs review » Reviewed & tested by the community

As per the above comment, I have ignored the failed test case.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 8.x-1.0 » 8.x-1.x-dev
Status: Reviewed & tested by the community » Needs work
pcate’s picture

pcate commented
Status: Needs work » Reviewed & tested by the community

I re-ran the tests with the latest supported version of D8 and D9 and they passed, so setting to RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/views_custom_cache_tag.module
@@ -0,0 +1,26 @@
+      $output .= '<p>' . t('The Views Custom Cache Tag module replaces the hardcoded cache tag with a form that allows developers to set different cache tags based on configuration of the view. It is also possible to set <a href=":cache_tags-documentation">cache tags </a> based on arguments/contextual filters. For more information, see the <a href=":views_custom_cache_tag">online for the Views Custom Cache Tag Module</a>.', [":cache_tags-documentation" => "https://www.drupal.org/docs/8/api/cache-api/cache-tags",":views_custom_cache_tag" => "https://www.drupal.org/project/views_custom_cache_tag"]) . '</p>';

The cache tags that are being replaced are not hardcoded. I think this module allows you to replace the often too generic list cache tag on views. For example: on a view of nodes you'll get the node_list cache tag. This module allows you to replace that with something more specific. A very important point is that you need to implement code to handle invalidating your new cache tag.

guilhermevp made their first commit to this issue’s fork.

guilhermevp opened merge request !1

guilhermevp’s picture

guilhermevp commented
Status: Needs work » Needs review

About updated based on comment#11.

nupur badola’s picture

nupur badola commented

Getting website encountered error.

thejimbirch’s picture

thejimbirch commented
Status: Needs review » Needs work
Related issues: +#2997407: README missing

back to Needs work for comment #15.

Consider also combining efforts with #2997407: README missing