According to Drupal standards, modules should include a useful README.file.

https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

CommentFileSizeAuthor
#7 interdiff-2997407-4-7.txt2.77 KBWebbeh
#7 2997407-7.patch1.9 KBWebbeh
#5 2997407-4.patch1.54 KBankush_03

Comments

Akshay kashyap created an issue. See original summary.

akshay kashyap’s picture

akshay kashyap commented
Status: Active » Needs work
siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: Unassigned » siddhant.bhosale
siddhant.bhosale’s picture

siddhant.bhosale commented
ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
Version: 8.x-1.0 » 8.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new 2997407-4.patch1.54 KB
akashkumar07’s picture

akashkumar07 commented
Status: Needs review » Needs work

Please remove extra trailing whitespace. Otherwise, patch looks good to me.
Thanks

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
StatusFileSize
new 2997407-7.patch1.9 KB
new interdiff-2997407-4-7.txt2.77 KB

Revised #5 to be more verbose for the 'No' sections. Also moved the call-to-action for the issue queue into a 'Troubleshooting section'.

Finally, removed trailing whitespace per #6 and standardized spacing per https://www.drupal.org/node/2181737 .

Interdiff and patch attached:

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
Status: Needs work » Needs review
siddhant.bhosale’s picture

siddhant.bhosale commented
Assigned: siddhant.bhosale » Unassigned
Status: Needs review » Reviewed & tested by the community

The patch applies cleanly and Looks Good To be Merged.

thejimbirch’s picture

thejimbirch commented
Status: Reviewed & tested by the community » Needs work

Thanks for the initial work on this.

  • It needs to be a merge request now, not a patch.
  • It talks about Drupal 8
  • It would be helpful to give examples of what tokens to use