Drupal 8 port [#2913473]

Problem/Motivation

This is some try to port the module to Drupal 8

Challenges:

Caching ... for some reason enabling response level caching breaks stuff
Incompatibilities with other modules like views_ajax_history, see #2913388: Disable URL replacement on GET requests in Drupal.Ajax.prototype.beforeSend

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#5	edit_drupal_8_port-2913473-1.patch	16.6 KB	Leon Kessler
#5
#4	interdiff-2913473.patch	294 bytes	Leon Kessler
#4
#4	2913473-3.patch	16.08 KB	Leon Kessler
#4
#2	2913473-2.patch	16.08 KB	dawehner
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

3 October 2017 at 09:04

dawehner created an issue. See original summary.

Comment #2

dawehner

German

CreditAttribution: dawehner at Chapter Three commented 3 October 2017 at 09:04

Status:

Active

» Needs review

File	Size
2913473-2.patch	16.08 KB

Comment #3

dawehner

German

CreditAttribution: dawehner at Chapter Three commented 3 October 2017 at 09:05

Issue summary:

View changes

Comment #4

Leon Kessler CreditAttribution: Leon Kessler commented 3 October 2017 at 10:15

Status:

Needs review

» Needs work

File	Size
2913473-3.patch	16.08 KB

interdiff-2913473.patch	294 bytes

Ah great!

Just tested out the patch, spotted one small issue with the incorrect path to the js file. Updated patch.

Also, we should update the README.txt with the new setup instructions.

Comment #5

Leon Kessler CreditAttribution: Leon Kessler commented 3 October 2017 at 11:16

Status:

Needs work

» Fixed

File	Size
edit_drupal_8_port-2913473-1.patch	16.6 KB

Patch with readme changes.

I think this is enough for now, I will push the 8.x-1.x branch and create a dev release.

Comment #6

dawehner

German

CreditAttribution: dawehner at Chapter Three commented 3 October 2017 at 11:19

@Leon Kessler
Thank you for your quick applying of the patch! I personally think that we need to solve the caching issues before a stable release of views ajax get. What do you think?

Comment #7

Leon Kessler CreditAttribution: Leon Kessler commented 3 October 2017 at 11:26

Yep I agree.

I'll setup another ticket for this, and will make a note on the module page about the issue.

Comment #8

dawehner

German

CreditAttribution: dawehner at Chapter Three commented 3 October 2017 at 11:30

👍
I'm glad you went with the "Let's iterate" approach instead of the "Let's make it perfect" approach.

Comment #9

Leon Kessler CreditAttribution: Leon Kessler commented 4 October 2017 at 09:14

Comment #10

Leon Kessler CreditAttribution: Leon Kessler commented 5 October 2017 at 16:21

@dawehner would you be able to put in some details about the caching issues you were experiencing on ticket https://www.drupal.org/node/2913754 (I'm having a bit of difficulty replicating it).