Type Error when using Webform fields

Are using twig to rewrite the field output?
Please post the complete error message here and also your views configuration (the exported yml file).

I was able to reproduce this issue in version 2.0.1 with the following steps:

1. Create a simple webform with a "textfield" field and a "number" field.
2. Create a view using the "Table with aggregation options" style.
3. Using Webform Views, add the webform submission data fields to the view.
4. In the style options, set the textfield to "Group and compress" and the number field to "Sum" for group aggregation.
5. Create at least two submissions in the webform with the same value for the textfield.

It appears that function renderNewWebformValue is incorrectly set to only accept array parameters for $new_values. The function is already set to convert non-array values to arrays, so I believe the type hinting should be removed.

Apologies, I actually had a secondary issue after fixing the type hinting. Following the same steps to reproduce as in #3 after applying the patch, the view itself no longer throws an error, but number field appears blank in the view with the following notice in the log:
Notice: Undefined index: number in Drupal\views_aggregator\Plugin\views\style\Table->renderNewWebformValue() (line 1067 of /var/www/html/web/modules/contrib/views_aggregator/src/Plugin/views/style/Table.php)
where "number" is the key of the number field webform component.

Why did you remove the checks for the rendered values?

It looks as though none of those checks will ever return TRUE, as they are all contained within if blocks for elements within the $rendered array. That is, the only case where $rendered can ever be empty is in the else.

I personally don't think that the magic method __toString() should ever be called directly. IMO if you want to coerce something to be a string you should use a cast.

Replaced __toString() calls with string casts per #7.

+1 for patch #8

I moved this to the current branch of this module, and I re-rolled the patch from #8 and put it into a MR so that it can be tested on GitLab CI.

None of the Wbform-specific code in this module is currently being tested at all. It is not maintainable. If we are going to make exceptions for Webform fields then we really really really need test cases for those exceptions. Can you write a simple test for this, hopefully without requiring the test to have a full install of Webform?

Hi,
I am sorry, I used this in an event-site which now is removed. So unfortunately I have no easy way to write test code (and check that it behaves correctly for this case.)

/Thomas

For there is still a bug, because of this error message
> Drupal\views_aggregator\Plugin\views\style\Table::renderNewWebformValue(): Argument #2 ($row_num) must be of type int, null given

changing this

protected function renderNewWebformValue(FieldHandlerInterface $field_handler, int $row_num, mixed $new_values, string $separator)

to this fixes it

protected function renderNewWebformValue(FieldHandlerInterface $field_handler, int|null $row_num, mixed $new_values, string $separator)

I added a comment to your merge request.

@sense-design: The problem you stated in #14 is not the same as this issue.
Your problem is #3495283: TypeError: Drupal\views_aggregator\Plugin\views\style\Table::setCell(): Argument #2 ($row_num) must be of type int, null given, and you should read the discussion there and contribute to a solution in that issue.

Oh sorry, missed that one. 👍