Drupal 9 compatibility

On #3042793: Drupal 9 Deprecated Code Report it was clear that there are no deprecated apis being used in the module. More over, we ensured there that non are introduced in the future by failing tests if its the case.

So it should be pretty much ready to go, once we sort out the main blocker: #3091388: Fix deprecations including jQuery UI dependency and info.yml update

Here's a patch to declare D9 compatibility. I noted that $defaultTheme is added to tests in the patch over in the linked issue (#3091388: Fix deprecations including jQuery UI dependency and info.yml update), so I left it out here.

Thanks for the patch.

1) Read through the change record:

https://www.drupal.org/node/3070687

and the patch does follow the recommendations in there:

a) Keeps core: 8.x

b) Adds core_version_requirement: ^8 || ^9

Note that the info file will need to be updated for the 9.x code to remove #1a and update #1b to core_version_requirement: ^8.8 || ^9.

2) Confirmed @katherined's comment about the deprecation notice from the failing tests:

Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

The patch in https://www.drupal.org/project/views_accordion/issues/3091388#comment-13... has $defaultTheme set:

protected $defaultTheme = 'stark';

3) Patch applies cleanly:

[mac:kristen:views_accordion]$ patch -p1 < 3100388-3.patch 
patching file views_accordion.info.yml

This is RTBC'ed but needs the code from #3091388: Fix deprecations including jQuery UI dependency and info.yml update committed first for tests to pass.

Whoops :)

@kapilkumar0324 Why did you add a new patch? It was not necessary. And you can't RTBC your own patch. Marking postponed until the other patch is committed.

Re #12 I think @kapilkumar0324 was trying to get the patch green. However on #3 it was clearly said that we were leaving adding the protected $defaultTheme to #3091388: Fix deprecations including jQuery UI dependency and info.yml update so it was indeed unnecessary.

+++ b/views_accordion.info.yml
@@ -2,5 +2,6 @@ name: Views Accordion
+core_version_requirement: ^8 || ^9

I haven't tested all this properly, but my understanding is that we are going to require at least core version 8.7 due to the move of the jquery ui library... should we change this line then?

Closing in favour of #3091388: Fix deprecations including jQuery UI dependency and info.yml update since it ends up we need to do both at the same time.

drupal 9 compatibility patch uploaded

fix patch

@valen0797 This issue was closed more than 2 years ago and the module is already compatible with Drupal 9.