Relocate calls to func_get_args() to beginnings of functions

Most calls to func_get_args() were already happening early. This patch addresses the remainder.

The diff does make it look slightly odd, but that moves $viewnames = _convert_csv_to_array(func_get_args()); to the top of the function.

 function views_revert_views() {
-  $views = views_get_all_views();
-  $i = 0;
   // The provided views names specified in the command.
   $viewnames = _convert_csv_to_array(func_get_args());
+  $views = views_get_all_views();
+  $i = 0;

In the context of the reason behind this issue, it would also be entirely reasonable to change this to:

  $args = func_get_args();
  // The provided views names specified in the command.
  $viewnames = _convert_csv_to_array($args);

or, closer to the original code:

  $args = func_get_args();
  $views = views_get_all_views();
  $i = 0;
  // The provided views names specified in the command.
  $viewnames = _convert_csv_to_array($args);

I'm happy to re-roll.

Damien, could you re-review the change I made to views_ui.module ?

Re-reading the patch, I'm aware that the way I've reordered things means that drupal_build_form($form_id, $form_state); is now called without the 'no_redirect' and 'rebuild_info' values which were previously in $form_state when this happened.

I obviously thought this was ok at the time, and now I'm not so sure. drupal_build_form() will trigger drupal_rebuild_form() if isset($_SESSION['batch_form_state']), so the sequence change no longer looks safe to me.

Here's the follow-up patch.

5c44b7f1 was the commit which added the preceding patch.

The new patch restores views_ui.module to its previous state (5c44b7f1^) except with (only) the code establishing $args moved.

diff-views_ui-5c44b7f1^-15.txt shows the difference between the previous state of views_ui.module and this new patch. If you commit this patch and check git diff 5c44b7f1^ views_ui.module you ought to see the same.