Since #853880: Views: Rewrite field, strips some HTML tags (SOLUTION/WORKAROUND FOUND FOR STYLE TAG) is locked I'm opening a new issue.

Problem: If I have a views_data_export XML display then it does not make sense to strip tags from the "rewrite results" content, because I want those tags in the XML output.

Solution: don't run filter_xss_admin() on the rewrite text because views editors are already trusted users with the "administer views" permission.

Although the Views maintainers don't seem to want to accept this I want to have my drush make patches in a public issue on drupal.org

CommentFileSizeAuthor
#2 views-no-alter-text-filter-2529948-2.patch781 bytesklausi
#1 views-no-alter-text-filter-2529948-1.patch772 bytesklausi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Active » Needs review
FileSize
views-no-alter-text-filter-2529948-1.patch772 bytes

Patch.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
FileSize
views-no-alter-text-filter-2529948-2.patch781 bytes

Rerolled for latest Views release.

vipul tulse’s picture

vipul tulse CreditAttribution: vipul tulse commented
Assigned: Unassigned » vipul tulse
MustangGB’s picture

MustangGB CreditAttribution: MustangGB commented
Assigned: vipul tulse » Unassigned

vipul tulse, why are you assigning so many issues to yourself?

If you're not actively working on a patch then there is no need, and this patch is already complete so there is nothing more to do.

You don't need to assign yourself if you only wish to review.

jvieille’s picture

jvieille CreditAttribution: jvieille commented

Thank you so much for giving the solution for this frustrating issue that was denied for ages by the Drupal Gurus.
This was really non-sense.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

@jvieille: that attitude is not necessary - the overwhelming majority of people maintaining and contributing to Drupal do so on a volunteer basis, you don't need to get condescending that a bug hasn't been fixed fast enough for you.

This patch needs some reviews, can someone please provide that? Thank you.

danieldd’s picture

danieldd CreditAttribution: danieldd commented

Thank you for making this change.

I've deployed the patch and can confirm it works as intended - in my case being able to add style tags to views fields, to enable display of background images.

I hope this can be rolled into an official release soon.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #2960871: Plan for Views 7.x-3.23 release

This is a small improvement, presuming the test coverage is still ok, I'm going to add it to 3.23.

  • DamienMcKenna committed 535ff98 on 7.x-3.x authored by klausi 
    Issue #2529948 by klausi, danieldd: Remove filter_xss_admin() from...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

BartNijs’s picture

BartNijs CreditAttribution: BartNijs commented

This doesn't work for translated views. In a translated custom text field, the style attribute still gets stripped out.
Any workaround for this?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

@Bartelli: Please open a new issue for that and we can work on it. Thanks.