Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Today while I was using EVA field to attach a view to a comment, I realized that views was missing a contextual filter for comment ID.
Comment | File | Size | Author |
---|---|---|---|
#1 | views-add_cid_argument-2219937-1.patch | 781 bytes | jenlampton |
Comments
Comment #1
jenlamptonPatch that adds comment ID data.
Comment #2
jenlamptonPatch still applies to latest version of views.
Comment #3
jenlamptonPatch applies to 7.x-3.15
Comment #4
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedJen's 5 year old patch to comment.views.inc applied cleanly to the latest views 7.x-3.x-dev and works great!
Comment #6
DamienMcKennaCommitted. Thanks jenlampton!
Comment #8
ron_s CreditAttribution: ron_s commentedFYI, this patch needs to be rolled back asap.
Comment ID already exists as an argument/filter/field, and this patch removes the ability to sort by overriding earlier code in
comment.views.inc
Please see my just posted patch: https://www.drupal.org/project/views/issues/3061720
Comment #9
DamienMcKennaFYI this was reverted in #3061720: Rollback of patch #2219937 for addition of comment ID because ultimately this duplicated keys added in another issue. Doh. Sorry about the confusion.
Comment #10
ron_s CreditAttribution: ron_s commentedThanks for taking care of it Damien, I appreciate it.