Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This could do with a few more comments to explain how the options form is made up of various subforms.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | views_docs-views_handler_filter-1424654-8.patch | 1.92 KB | Jerenus |
| #5 | 1424654-followup.views_.docs-views_handler_filter-value-form.patch | 699 bytes | joachim |
| #1 | 1424654.views_.docs-views_handler_filter.patch | 1.91 KB | joachim |
Comments
Comment #1
joachim CreditAttribution: joachim commentedI've standardized the docblock for each of the subforms and added some comments in option_form() that refer to them. This should help make exposed_form() / expose_form() less confusing too.
Comment #2
dawehnerThanks!
Committed to 7.x-3.x, would be worth for 6.x-3.x as well.
Sadly the patch doesn't apply there
Comment #3
joachim CreditAttribution: joachim commentedHum actually is value_form() used for both the admin options and the actual exposed form?
Comment #4
dawehnerRight it's the form of the value.
Comment #5
joachim CreditAttribution: joachim commentedOkay so this is a follow-on patch that makes that clearer.
Comment #6
esmerel CreditAttribution: esmerel commentedit does not want to be applied! There is no love from the patching patchy patcher.
Comment #8
Jerenus CreditAttribution: Jerenus commentedNew one for the Head(6.x-3.x-dev).
Comment #9
dawehnerThanks for writing this patch, though I'm wondering whether we should simply skip 6.x-3.x from now on?
Comment #10
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedComment #11
joachim CreditAttribution: joachim as a volunteer commentedThis doesn't seem to have been committed, or at least, pushed?