Fix PHPCS issues [#3476618]

Problem/Motivation

Currently the PHPCS CI job shows the following issues:

FILE: ...w_mode_switch/tests/src/Unit/Entity/EntityViewModeDeleteFormHelperTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 13 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\Tests\UnitTestCase.
    |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...s/custom/view_mode_switch/tests/src/Unit/Entity/EntityFieldManagerTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 11 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\Tests\UnitTestCase.
    |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...tch/tests/src/Kernel/Plugin/Field/FieldWidget/ViewModeSwitchWidgetTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\Tests\view_mode_switch\Kernel\ViewModeSwitchTestBase.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ..._switch/tests/src/Kernel/Plugin/Field/FieldType/ViewModeSwitchItemTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 13 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is
    |       |     Drupal\Tests\view_mode_switch\Kernel\ViewModeSwitchTestBase.
    |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...tch/tests/src/Kernel/Plugin/Field/FieldType/ViewModeSwitchItemListTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\Tests\view_mode_switch\Kernel\ViewModeSwitchTestBase.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ts/src/Kernel/Plugin/Field/FieldFormatter/ViewModeSwitchFormattersTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\Tests\view_mode_switch\Kernel\ViewModeSwitchTestBase.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...mode_switch/tests/src/Kernel/Entity/EntityViewModeDeleteFormHelperTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\Tests\view_mode_switch\Kernel\ViewModeSwitchTestBase.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...custom/view_mode_switch/tests/src/Kernel/Entity/EntityFieldManagerTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\Tests\view_mode_switch\Kernel\ViewModeSwitchTestBase.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...custom/view_mode_switch/tests/src/Functional/ViewModeSwitchFieldUITest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Tests\field_ui\Traits\FieldUiTestTrait.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...es/custom/view_mode_switch/tests/src/Functional/ViewModeSwitchDiffTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\Tests\view_mode_switch\Traits\ViewModeSwitchTestTrait.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...iew_mode_switch/src/Plugin/Field/FieldType/ViewModeSwitchItemInterface.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 62 | ERROR | [x] Parameter $account has null default value, but is not marked
    |       |     as nullable.
    |       |     (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
 76 | ERROR | [x] Parameter $account has null default value, but is not marked
    |       |     as nullable.
    |       |     (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../custom/view_mode_switch/src/Plugin/Field/FieldType/ViewModeSwitchItem.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
 162 | ERROR | [x] Parameter $account has null default value, but is not marked
     |       |     as nullable.
     |       |     (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
 183 | ERROR | [x] Parameter $account has null default value, but is not marked
     |       |     as nullable.
     |       |     (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
 195 | ERROR | [x] Parameter $account has null default value, but is not marked
     |       |     as nullable.
     |       |     (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
 230 | ERROR | [x] Parameter $account has null default value, but is not marked
     |       |     as nullable.
     |       |     (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 926ms; Memory: 12MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE                                                            ERRORS  WARNINGS
--------------------------------------------------------------------------------
...de_switch/src/Plugin/Field/FieldType/ViewModeSwitchItem.php  4       0
.../src/Plugin/Field/FieldType/ViewModeSwitchItemInterface.php  2       0
...mode_switch/tests/src/Functional/ViewModeSwitchDiffTest.php  1       0
...e_switch/tests/src/Functional/ViewModeSwitchFieldUITest.php  1       0
...e_switch/tests/src/Kernel/Entity/EntityFieldManagerTest.php  1       0
...ts/src/Kernel/Entity/EntityViewModeDeleteFormHelperTest.php  1       0
...lugin/Field/FieldFormatter/ViewModeSwitchFormattersTest.php  1       0
...ernel/Plugin/Field/FieldType/ViewModeSwitchItemListTest.php  1       0
...rc/Kernel/Plugin/Field/FieldType/ViewModeSwitchItemTest.php  1       0
...ernel/Plugin/Field/FieldWidget/ViewModeSwitchWidgetTest.php  1       0
...ode_switch/tests/src/Unit/Entity/EntityFieldManagerTest.php  1       0
...ests/src/Unit/Entity/EntityViewModeDeleteFormHelperTest.php  1       0
--------------------------------------------------------------------------------
A TOTAL OF 16 ERRORS AND 0 WARNINGS WERE FOUND IN 42 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 16 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
--------------------------------------------------------------------------------
    SOURCE                                                                 COUNT
--------------------------------------------------------------------------------
[x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.Incorrectl  10
[x] SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.Null  6
--------------------------------------------------------------------------------
A TOTAL OF 16 SNIFF VIOLATIONS WERE FOUND IN 2 SOURCES
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SOURCES AUTOMATICALLY (16 VIOLATIONS IN TOTAL)
--------------------------------------------------------------------------------

Proposed resolution

Fix PHPCS issues

Remaining tasks

Create issue fork and MR to fix this issue

Issue fork view_mode_switch-3476618

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3476618-fix-phpcs-issues changes, plain diff MR !42
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

25 September 2024 at 07:49

hctom created an issue. See original summary.

Comment #2

25 September 2024 at 08:04

hctom opened merge request !42

Comment #3

25 September 2024 at 11:07

hctom committed 48db772f on 2.x

Issue #3476618 by hctom: Fix PHPCS issues

Comment #4

hctom

German

commented 25 September 2024 at 11:07

Status:

Active

» Fixed

Done - all green again ;)

Comment #5

hctom

German

commented 25 September 2024 at 11:08

Status:

Fixed

» Closed (fixed)

Fix PHPCS issues

Problem/Motivation

Proposed resolution

Remaining tasks

Issue fork view_mode_switch-3476618

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

News items

Our community

Documentation

Drupal code base

Governance of community