Please, use CSS selectors in the output of the filter. I'm aware of #369674: Wrap output in DIV tag, however there are so many CSS-only themes out there, and having to create a theme function/template for them is overkill.

Something like:

<object class="filtered-video left" type="application/x-shockwave-flash"...</object>

For greater control of filtered videos, it would be a plus if unique classes are also defined:

<object class="filtered-video left video-youtube-1HFrmVq0Idw" type="application/x-shockwave-flash"...</object>

BTW, thanks for this great module.

CommentFileSizeAuthor
#3 video_filter_581370-2.patch2.52 KBblackdog
#2 video_filter_581370.patch6.46 KBanon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented

lovely idea!

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Status: Active » Needs review
FileSize
video_filter_581370.patch6.46 KB

Patch:

<object class="video-filter video-filter-6928356" ...>...</object>
Vimeo http://vimeo.com/6928356

<object class="video-filter video-filter-5hXZxaGZ_Bo" ...>...</object>
Youtube http://www.youtube.com/watch?v=5hXZxaGZ_Bo

The class "video-filter-XXXXX" is dynamic and the value is defined in the codec file for every codec.

blackdog’s picture

blackdog CreditAttribution: blackdog commented
FileSize
video_filter_581370-2.patch2.52 KB

I like the approach, but I don't like adding new code to every codec. I've taken a different approach, see attached patch.

This would also move video_filter.css up from the wysiwyg folder to the module root folder, so the alignment work.

blackdog’s picture

blackdog CreditAttribution: blackdog commented
Status: Needs review » Fixed

I've committed this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.