Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I started getting the following warning recently with the Brightcove shortcode.
Warning: A non-numeric value encountered in Drupal\video_filter\Plugin\Filter\VideoFilter->process() (line 153 of modules/contrib/video_filter/src/Plugin/Filter/VideoFilter.php)
Happens with shortcodes like:
[video:https://players.brightcove.net/1094142158001/default_default/index.html?videoId=5429110862001]
If we use is_numeric near line 153 when doing scale operations it seems to fix the issue with no rendering side effects.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2931811_check_numeric_scale_factor.patch | 632 bytes | Anonymous (not verified) |
|
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedvilepickle created an issue. See original summary.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #3
fredklopper CreditAttribution: fredklopper commented#2 Works like a charm. Thanks!
Comment #4
tjtj CreditAttribution: tjtj commentedI am getting this now with Drupal 8.8.5:
A non-numeric value encountered in Drupal\video_filter\Plugin\Filter\VideoFilter->process() (line 160 of /home//public_html/drupal/modules/video_filter/src/Plugin/Filter/VideoFilter.php)
Comment #5
tjtj CreditAttribution: tjtj commentedI am still getting this in 8.9.1!
Comment #6
wylbur CreditAttribution: wylbur at Electric Citizen commentedApplied this patch to To resolve the same errors as in comment #4.
Adding this as a child issue to Plan for a new release.
Comment #7
DamienMcKennaComment #9
DamienMcKennaCommitted. Thank you.