I started getting the following warning recently with the Brightcove shortcode.

Warning: A non-numeric value encountered in Drupal\video_filter\Plugin\Filter\VideoFilter->process() (line 153 of modules/contrib/video_filter/src/Plugin/Filter/VideoFilter.php)

Happens with shortcodes like:

[video:https://players.brightcove.net/1094142158001/default_default/index.html?videoId=5429110862001]

If we use is_numeric near line 153 when doing scale operations it seems to fix the issue with no rendering side effects.

CommentFileSizeAuthor
#2 2931811_check_numeric_scale_factor.patch632 bytesAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

vilepickle created an issue. See original summary.

Anonymous’s picture

Status: Active » Needs review
FileSize
632 bytes
fredklopper’s picture

#2 Works like a charm. Thanks!

tjtj’s picture

I am getting this now with Drupal 8.8.5:
A non-numeric value encountered in Drupal\video_filter\Plugin\Filter\VideoFilter->process() (line 160 of /home//public_html/drupal/modules/video_filter/src/Plugin/Filter/VideoFilter.php)

tjtj’s picture

I am still getting this in 8.9.1!

wylbur’s picture

Applied this patch to To resolve the same errors as in comment #4.

Adding this as a child issue to Plan for a new release.

DamienMcKenna’s picture

Assigned: » Unassigned
Status: Needs review » Reviewed & tested by the community

DamienMcKenna’s picture

Status: Reviewed & tested by the community » Fixed

Committed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.