The video filter embed button in CKEditor pop up works fine in Chrome and Firefox, but on Safari, when you click the cancel or insert button, the pop up doesn't work. It just remains open.

Sometimes, the insert works the first time you try it, then it hangs on any additional insert.

I'm on Safari 9.1.1, FF 46 and Chrome 51.
CKEditor version 7.x-1.17

CommentFileSizeAuthor
#6 2749267-fix-safari-problems.patch1.12 KBjsobiecki
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstermitz created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Version: 7.x-3.4 » 7.x-3.x-dev
Status: Active » Postponed (maintainer needs more info)

I just tested this with Safari 10 (on El Capitan) and it's working.

Can you please let me know if any error messages show in the Safari's developer console?

lreynaga’s picture

lreynaga CreditAttribution: lreynaga as a volunteer commented

I am able to replicate this. I am also attaching an image (https://www.evernote.com/l/AjUCsYmgyZREM6lk6-cEUZyEcBMxP3MRjT4) of how the pop-up window looks, and the console error you get when you try clicking the "Instert" button.

OS X El Capitan v10.11.4
Safari: Version 9.1 (11601.5.17.1)
CKEditor Version: 7.x-1.17+4-dev

rmajed’s picture

rmajed CreditAttribution: rmajed as a volunteer commented

I am facing the same problem ..
in file video_filter_dialog.js
line 10
CKEDITOR = dialogArguments.opener.CKEDITOR;

ERROR on safari:

can't find variable: dialogArguments

that’s my version of Safari Version 11.0.3 (13604.5.6)

rmajed’s picture

rmajed CreditAttribution: rmajed as a volunteer commented
Status: Postponed (maintainer needs more info) » Needs work
jsobiecki’s picture

jsobiecki CreditAttribution: jsobiecki at RatioWeb commented
FileSize
2749267-fix-safari-problems.patch1.12 KB

For me it looks like Safari is slowly withdrawing deprecated window.showModalDialog (and related dialogArguments variable). Problem is caused by a fact, that althrough window.showModalDialog still exists, it doesn't behave correctly.

As showModalDialog is deprecated, I tried to simple remove reference to this (patch attached) and it looks that it solved my problem.

jsobiecki’s picture

jsobiecki CreditAttribution: jsobiecki at RatioWeb commented
Status: Needs work » Needs review