Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I added twitch stream support to video filter and would like to share.
Example video url:
http://www.twitch.tv/esfkamiab
Comment | File | Size | Author |
---|---|---|---|
#5 | video_filter-twitch-2232969-5-D7.patch | 996 bytes | walangitan |
#1 | video_filter-twitch-2232959-1-D7.patch | 1.13 KB | Cryr |
Comments
Comment #1
Cryr CreditAttribution: Cryr commentedComment #2
ultimateboy CreditAttribution: ultimateboy commentedI'm fine with adding twitch support if whitespace issues in this patch as resolved.
Please refer to https://www.drupal.org/coding-standards if you have any questions.
Comment #3
NBZ4live CreditAttribution: NBZ4live commentedHi. I made a project video_filter_twitch.
It adds a twitch.tv codec to the video filter.
It supports the normal channel/live streams and archive streams.
Comment #4
ultimateboy CreditAttribution: ultimateboy commentedInstead of creating a new module, I would have very quickly applied a patch that passed Drupal's coding standards. The code in your module looks great to just pull in as is.
I'll find some time to turn your module's code in to a patch and add it to this module soon... somebody can always help me out by providing the patch for me though :)
Comment #5
walangitan CreditAttribution: walangitan at Chromatic commentedUpdated patch which uses the HTML5 iframe instead of flash for twitch. Simplified compared to the standalone module NBZ4live wrote video_filter_twitch. If we need the extra functionality I can port it over. This patch is simply embeds a twitch channel, similar to how their embed code would work.
Notes for testing
Used the following tokens for testing:
I am seeing an issue on simplytest.me where I am only able to get videos to render if the Limit allowed HTML tags filter is above the video filter in the filter processing order on the text formats configuration page. Twitch also returns an empty iframe on simpletest, but applying the patch on my local machine renders the full twitch iframe.
Comment #6
walangitan CreditAttribution: walangitan at Chromatic commentedComment #7
minnur CreditAttribution: minnur at Chapter Three commentedThis has been added to D8 version of the module.
Comment #9
DamienMcKennaCommitted.
Comment #10
minnur CreditAttribution: minnur at Chapter Three commented