Update Vidyard embed code (v4)

Agreed, dependency change should have been part of #3035286: Update Dependencies to new Format in .info.yml, I'll post an updated patch without it.

The styles removed by this patch (#2) was used to create a responsive embed experience.

--- a/css/video_embed_vidyard.css
+++ /dev/null
@@ -1,15 +0,0 @@
-/* Set vidyard span wrappers for responsive videos. */
-/* Ref: http://knowledge.vidyard.com/33007-publish-your-player/245140-make-an-inline-player-responsive */
-.video-embed-field-responsive-video .vidyard_player {
-  position: absolute;
-  top: 0;
-  left: 0;
-  width: 100%;
-  height: 100%;
-}
-
-.video-embed-field-responsive-video .vidyard_player > span {
-  width: 100% !important;
-  height: 100% !important;
-  margin: 0 auto !important;
-}

Vidyard's v4 implementation introduced in this patch, already creates a responsive embed markup. Though I opted to remove the inline CSS width: 100%; margin: auto; display: block; introduced by Vidyard's official responsive embed code. Drupal doesn't need that inline CSS, IMO.

Eric, at first glance I overlooked the existence of the video_embed_field/templates/video-embed-iframe.html.twig, then thought a template could be added as a new feature in a separate issue.

But, I'll see if I can update the patch with a twig template, later in the day.

Do you see any other issues may need addressing?

With added patch, the template variables can now be altered as defined in video_embed_field.

function hook_preprocess_video_embed_iframe__vidyard(&$variables) {
  // Add new attributes.
  $variables['attributes']['data-genre'] = 'Sci-Fi';
}