The return type for the getIdFromInput() method on the ProviderPluginInterface, should be string|false, not just string, as stated on the current method annotations. Both the Vimeo and YouTube plugin implementations will return string or FALSE. I had to create a custom video plugin and had linter issues as a consequence.

CommentFileSizeAuthor
#2 3486794-wrong-return-type.patch523 bytesjosé trindade

Issue fork video_embed_field-3486794

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

josé trindade created an issue. See original summary.

josé trindade’s picture

josé trindade commented
StatusFileSize
new 3486794-wrong-return-type.patch523 bytes
divyansh.gupta’s picture

divyansh.gupta commented
Assigned: Unassigned » divyansh.gupta

Reviewing it!

divyansh.gupta opened merge request !54

divyansh.gupta’s picture

divyansh.gupta commented
Assigned: divyansh.gupta » Unassigned
Status: Active » Needs review

I reviewed the patch and it was successfully applied, so provided an MR for the same,
Please review.

kul.pratap’s picture

kul.pratap commented
Status: Needs review » Needs work

Please resolve the pipeline issue.

divyansh.gupta’s picture

divyansh.gupta commented
Status: Needs work » Needs review

Found that pipelines were failing because forked branch was some commits behind the main branch, so rebased my forked branch and ran the pipeline again and now all the pipelines are passing without errors/warnings.
Please review.

kul.pratap’s picture

kul.pratap commented
Status: Needs review » Reviewed & tested by the community

Since now the pipeline is green so moving this to RTBC.

mably made their first commit to this issue’s fork.

mably’s picture

mably commented
Version: 8.x-2.5 » 3.0.x-dev
Status: Reviewed & tested by the community » Fixed
mably’s picture

mably commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.