Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There are some coding standard issues in module.
Comment | File | Size | Author |
---|---|---|---|
#8 | coding_standards-2886360-8.patch | 28.46 KB | Deepthi kumari |
#8 | coding_standards_diff.txt | 13.84 KB | Deepthi kumari |
#7 | 2886360-coding-standard-7.patch | 3.42 KB | deepanker_bhalla |
#5 | video_embed_field_coding_standard-2886360-5.patch | 15.29 KB | jayesh_makwana |
#2 | video_embed_field_coding_standard-2886360-2.patch | 15.3 KB | jayesh_makwana |
Comments
Comment #2
jayesh_makwana CreditAttribution: jayesh_makwana at cmsMinds commentedWe create a patch for solving coding standard issues for this module. Please check and apply it.
Comment #3
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedComment #5
jayesh_makwana CreditAttribution: jayesh_makwana at cmsMinds commented@Sam152
Hello,
Sorry for failure of coding standard patch for this module. I checked properly yesterday in my site and it worked properly. Now i recreate patch file again for module and check again. It's working properly. Please check recreate patch and review.
Thank You.
Comment #6
deepanker_bhalla CreditAttribution: deepanker_bhalla as a volunteer and at Srijan | A Material+ Company commented@jayesh_makwana Good work. I can confirm the patch #5 is applying cleanly. Here is the output:
❯ video_embed_field 8.x-1.x* git apply -v video_embed_field_coding_standard-2886360-5.patch
Checking patch modules/video_embed_media/src/UpgradeManager.php...
Checking patch modules/video_embed_wysiwyg/src/Plugin/Filter/VideoEmbedWysiwyg.php...
....and more...
Applied patch modules/video_embed_media/src/UpgradeManager.php cleanly.
Applied patch modules/video_embed_wysiwyg/src/Plugin/Filter/VideoEmbedWysiwyg.php cleanly.
....and more....
❯ video_embed_field 8.x-1.x* phpcs --standard=Drupal .
_________________________________________________________________________________________________________
But after checking with phpcs --standard=Drupal video_embed_field/....... I am getting some more issues i.e.
Comment #7
deepanker_bhalla CreditAttribution: deepanker_bhalla as a volunteer and at Srijan | A Material+ Company commentedThus i am uploading the patch to resolved the remaining ones too.
Comment #8
Deepthi kumari CreditAttribution: Deepthi kumari as a volunteer and at TA Digital commentedFound a few more issues after applying patch #7. Applied Patch. Please review.
Comment #9
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedWith the advent of Media in core, the Video Embed Field module has moved to being minimally maintained. Only issues which assist in the migration to Media in core will be committed. To read more about this decision, please see: #3089599: Maintenance status for Video Embed Field now that media is in core.