Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The max length of the video embed field is set at 256 and is not customizable based on field base. Is there a reason this is necessary? It makes it not possible to add a custom provider to handle input that for instance may need a long query string or intends to accept actual iframe embed code.
Comment | File | Size | Author |
---|---|---|---|
#3 | video_embed_field-url_max_length-2871851-3-D8.patch | 472 bytes | gregnz |
Comments
Comment #2
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedI don't see a reason why this shouldn't just be bigger. Not sure there'll be much of a performance penalty. What size would you suggest?
Comment #3
gregnz CreditAttribution: gregnz at Catalyst IT commentedSection 3.2.1 of http://www.faqs.org/rfcs/rfc2616.html suggests it should be configurable to allow users to set the length to handle the expected content.
Referencing https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of... this patch sets the max length to 2048 chars which will handle most real world cases without being configurable.
Comment #4
xurizaemonUpdating title - we're not making it customizable, we're increasing it to allow for what's commonly supported.
Comment #5
xurizaemonComment #6
RoSk0I'm fine with setting it to that size. However we need couple things done here as well: 1) issue summary 2) upgrade path
Comment #7
xurizaemonBased on secret knowledge, I think Greg's patch is being submitted to 8.x-2.x branch not 8.x-1.x.
Comment #8
RichardDavies CreditAttribution: RichardDavies at City of Portland commentedAfter applying this patch, I get the following error in my status report:
How do I resolve that error now that Drupal 8.7 has removed support for drush entup?
Comment #9
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedWithout an upgrade path, using this patch would require all the fields to be deleted and the module be installed and reinstalled. I think at this stage, it's probably too disruptive to consider.
Comment #10
RichardDavies CreditAttribution: RichardDavies at City of Portland commentedHmm, thanks for the response, but this issue shouldn't be closed just because the patch was incomplete. This is still very much an issue that I would like to be resolved. If I understand correctly, the patch just needs to include an update function to update any existing fields as described in https://www.drupal.org/node/3034742.
Comment #11
Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commentedThere is no current supported way to update field level schema. At this stage I would consider an unsupported upgrade path way too risky for the other 62,000 installs that don't require this issue. Feel free to write and share patches for this, but I think it's a stretch to put that level of disruption on sites, for a module that is slowly becoming defunct.