Problem/Motivation

Based on some comments in #2747173: Fatal error: Call to a member function downloadThumbnail() on a non-object and the open issue #2781833: "Multi step selection display" somehow causes an empty media entity to enter MediaType plugins., it looks like some interaction between inline entity form, entity browser and the multi-step selection display cause a media entity to be saved without any of it's fields set. I've stepped through this code and am struggling to understand the problem.

The other MediaType plugins are more resilient to this, perhaps we should do the same?

Proposed resolution

Patch and see what the impact is.

Remaining tasks

Patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Status: Needs review » Needs work

The last submitted patch, 2: 2782381-never-assume-source-field-2.patch, failed testing.

The last submitted patch, 2: 2782381-never-assume-source-field-2.patch, failed testing.

The last submitted patch, 2: 2782381-never-assume-source-field-2.patch, failed testing.

The last submitted patch, 2: 2782381-never-assume-source-field-2.patch, failed testing.

Sam152’s picture

Sam152’s picture

Status: Needs review » Fixed

  • Sam152 committed 54dd2bd on 8.x-1.x
    Issue #2782381 by Sam152: Never assume media entities passed to the...
Sam152’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.